Remove invalid destruction of parameters by the callee in extensions methods

Author: touilleMan

src/godot/_lang_resource_format_loader.pxi

@@ -17,7 +17,6 @@ cdef class PythonResourceFormatLoader:
     cdef inline gd_packed_string_array_t _get_dependencies(self, gd_string_t path, gd_bool_t add_types):
         cdef gd_packed_string_array_t dependencies = gd_packed_string_array_new()
         cdef object py_path = gdapi.gd_string_to_pystr(&path)
-        gd_string_del(&path)
 
         spy_log(f"CALLED PythonResourceFormatLoader::_get_dependencies(path={py_path}, add_types={add_types})")
 
@@ -67,7 +66,6 @@ cdef class PythonResourceFormatLoader:
             ret = gd_string_name_op_equal_string(&type, &candidate)
             gd_string_del(&candidate)
 
-        gd_string_name_del(&type)
         return ret
 
     # godot_extension: method(virtual=True, const=True)
@@ -76,7 +74,6 @@ cdef class PythonResourceFormatLoader:
         cdef object py_extension
 
         py_path = gdapi.gd_string_to_pystr(&path)
-        gd_string_del(&path)
 
         spy_log(f"CALLED PythonResourceFormatLoader::_get_resource_type(path={py_path!r})")
 
@@ -91,8 +88,6 @@ cdef class PythonResourceFormatLoader:
         cdef gd_variant_t ret = gd_variant_new()
         cdef str py_path = gdapi.gd_string_to_pystr(&path)
         cdef str py_original_path = gdapi.gd_string_to_pystr(&original_path)
-        gd_string_del(&path)
-        gd_string_del(&original_path)
         spy_log(f"CALLED PythonResourceFormatLoader::_load(path={py_path!r}, original_path={py_original_path!r}, use_sub_threads={use_sub_threads}, cache_mode={cache_mode})")
 
         # 1) Check path and convert it to Python format (e.g. `res://foo/bar.py` -> `foo.bar`)

src/godot/_lang_resource_format_saver.pxi

@@ -60,7 +60,6 @@ cdef class PythonResourceFormatSaver:
 
         # Convert the path to a Python string
         cdef object py_path = gdapi.gd_string_to_pystr(&path)
-        gd_string_del(&path)
 
         spy_log("CALLED PythonResourceFormatSaver::_save(resource=<resource>, path={py_path!r}, flags={flags})")
 

src/godot/_lang_script.pxi

@@ -68,10 +68,7 @@ cdef class PythonScript:
         spy_log(f"CALLED PythonScript::_get_member_line(member={gdapi.gd_string_name_to_pystr(&member)!r})")
 
         # Convert string name to string, then to Python string
-        cdef gd_string_t member_str = gdapi.gd_string_new_from_string_name(&member)
-        cdef object py_member = gdapi.gd_string_to_pystr(&member_str)
-        gd_string_del(&member_str)
-        gd_string_name_del(&member)
+        cdef object py_member = gdapi.gd_string_name_to_pystr(&member)
 
         # Find the line where the member is defined
         if not self._source_code:
@@ -99,15 +96,13 @@ cdef class PythonScript:
         spy_log(f"CALLED PythonScript::_get_method_info(method={gdapi.gd_string_name_to_pystr(&method)!r})")
         # TODO
         cdef gd_dictionary_t ret = gd_dictionary_new()
-        gd_string_name_del(&method)
         return ret
 
     # godot_extension: method(virtual=True, const=True)
     cdef inline gd_variant_t _get_property_default_value(self, gd_string_name_t property):
         spy_log(f"CALLED PythonScript::_get_property_default_value(property={gdapi.gd_string_name_to_pystr(&property)!r})")
         # TODO
         cdef gd_variant_t ret = gd_variant_new()
-        gd_string_name_del(&property)
         return ret
 
     # godot_extension: method(virtual=True, const=True)
@@ -153,10 +148,7 @@ cdef class PythonScript:
     cdef inline gd_bool_t _has_method(self, gd_string_name_t method):
         spy_log(f"CALLED PythonScript::_has_method(method={gdapi.gd_string_name_to_pystr(&method)!r})")
         # Convert string name to string, then to Python string
-        cdef gd_string_t method_str = gdapi.gd_string_new_from_string_name(&method)
-        cdef object py_method = gdapi.gd_string_to_pystr(&method_str)
-        gd_string_del(&method_str)
-        gd_string_name_del(&method)
+        cdef object py_method = gdapi.gd_string_name_to_pystr(&method)
 
         # Check if method exists in the Python source code
         if not self._source_code:
@@ -175,14 +167,12 @@ cdef class PythonScript:
     cdef inline gd_bool_t _has_property_default_value(self, gd_string_name_t property):
         spy_log(f"CALLED PythonScript::_has_property_default_value(property={gdapi.gd_string_name_to_pystr(&property)!r})")
         # TODO
-        gd_string_name_del(&property)
         return False
 
     # godot_extension: method(virtual=True, const=True)
     cdef inline gd_bool_t _has_script_signal(self, gd_string_name_t signal):
         spy_log(f"CALLED PythonScript::_has_script_signal(signal={gdapi.gd_string_name_to_pystr(&signal)!r})")
         # TODO
-        gd_string_name_del(&signal)
         return False
 
     # godot_extension: method(virtual=True, const=True)
@@ -194,7 +184,6 @@ cdef class PythonScript:
     cdef inline gd_bool_t _inherits_script(self, gd_object_t script):
         spy_log(f"CALLED PythonScript::_inherits_script(script=<object 0x{<size_t>script:x}>)")
         # TODO
-        # `gd_object_t` doesn't need to be be deleted (is it just a raw pointer)
         return False
 
     # godot_extension: method(virtual=True, const=True)
@@ -218,7 +207,6 @@ cdef class PythonScript:
         spy_log(f"CALLED PythonScript::_instance_has(object=<object 0x{<size_t>object:x}>)")
         # Check if the given object is an instance of this script
         # For now return False as we don't track instances yet
-        # `gd_object_t` doesn't need to be be deleted (is it just a raw pointer)
         return False
 
     # godot_extension: method(virtual=True, const=True)
@@ -258,7 +246,6 @@ cdef class PythonScript:
     cdef inline void* _placeholder_instance_create(self, gd_object_t for_object):
         spy_log(f"CALLED PythonScript::_placeholder_instance_create(for_object=<object 0x{<size_t>for_object:x}>)")
         # Create a placeholder instance for when the script is not ready
-        # `gd_object_t` doesn't need to be be deleted (is it just a raw pointer)
         return NULL
 
     # godot_extension: method(virtual=True)
@@ -274,7 +261,6 @@ cdef class PythonScript:
     cdef inline void _set_source_code(self, gd_string_t code):
         self._source_code = gdapi.gd_string_to_pystr(&code)
         spy_log(f"CALLED PythonScript::_set_source_code(code={self._source_code!r})")
-        gd_string_del(&code)
 
     # godot_extension: method(virtual=True)
     cdef inline void _update_exports(self):

src/godot/_lang_script_language.pxi

@@ -16,15 +16,11 @@ cdef class PythonScriptLanguage:
     cdef inline void _add_global_constant(self, gd_string_name_t name, gd_variant_t value):
         # TODO
         spy_log(f"CALLED PythonScriptLanguage::_add_global_constant(name={gdapi.gd_string_name_to_pystr(&name)!r}, value={value!r})")
-        gd_string_name_del(&name)
-        gd_variant_del(&value)
 
     # godot_extension: method(virtual=True)
     cdef inline void _add_named_global_constant(self, gd_string_name_t name, gd_variant_t value):
         # TODO
         spy_log(f"CALLED PythonScriptLanguage::_add_named_global_constant(name={gdapi.gd_string_name_to_pystr(&name)!r}, value={value!r})")
-        gd_string_name_del(&name)
-        gd_variant_del(&value)
 
     # godot_extension: method(virtual=True, const=True)
     cdef inline gd_string_t _auto_indent_code(self, gd_string_t code, gd_int_t from_line, gd_int_t to_line):
@@ -48,9 +44,6 @@ cdef class PythonScriptLanguage:
         # TODO
         spy_log(f"CALLED PythonScriptLanguage::_complete_code(code={gdapi.gd_string_to_pystr(&code)!r}, path={gdapi.gd_string_to_pystr(&path)!r}, owner=<object 0x{<size_t>owner:x}>)")
         cdef gd_dictionary_t ret = gd_dictionary_new()
-        gd_string_del(&code)
-        gd_string_del(&path)
-        # `gd_object_t` doesn't need to be be deleted (is it just a raw pointer)
         return ret
 
     # godot_extension: method(virtual=True, const=True)
@@ -133,8 +126,6 @@ cdef class PythonScriptLanguage:
         spy_log(f"CALLED PythonScriptLanguage::_find_function(function={gdapi.gd_string_to_pystr(&function)!r}, code={gdapi.gd_string_to_pystr(&code)!r})")
         cdef object py_function = gdapi.gd_string_to_pystr(&function)
         cdef object py_code = gdapi.gd_string_to_pystr(&code)
-        gd_string_del(&function)
-        gd_string_del(&code)
 
         # Simple search for function definition
         try:
@@ -164,7 +155,6 @@ cdef class PythonScriptLanguage:
     cdef inline gd_array_t _get_built_in_templates(self, gd_string_name_t object):
         # TODO
         spy_log(f"CALLED PythonScriptLanguage::(object={gdapi.gd_string_name_to_pystr(&object)!r})")
-        gd_string_name_del(&object)
         cdef gd_array_t ret = gd_array_new()
         return ret
 
@@ -203,7 +193,6 @@ cdef class PythonScriptLanguage:
     cdef inline gd_dictionary_t _get_global_class_name(self, gd_string_t path):
         # TODO
         spy_log(f"CALLED PythonScriptLanguage::_get_global(path={gdapi.gd_string_to_pystr(&path)!r})")
-        gd_string_del(&path)
         cdef gd_dictionary_t ret = gd_dictionary_new()
         return ret
 
@@ -316,7 +305,6 @@ cdef class PythonScriptLanguage:
         spy_log(f"CALLED PythonScriptLanguage::_handles_global_class_type(type={gdapi.gd_string_to_pystr(&type)!r})")
         # TODO: would be more efficient to precompute the type into a `gd_string_t`
         cdef gd_bool_t result = gdapi.gd_string_to_pystr(&type) == "Python"
-        gd_string_del(&type)
         return result
 
     # godot_extension: method(virtual=True, const=True)
@@ -349,7 +337,6 @@ cdef class PythonScriptLanguage:
             "when",
             "while",
         )
-        gd_string_del(&keyword)
         return result
 
     # godot_extension: method(virtual=True)
@@ -361,10 +348,6 @@ cdef class PythonScriptLanguage:
     cdef inline gd_dictionary_t _lookup_code(self, gd_string_t code, gd_string_t symbol, gd_string_t path, gd_object_t owner):
         # TODO
         spy_log(f"CALLED PythonScriptLanguage::_lookup_code(code={gdapi.gd_string_to_pystr(&code)!r}, symbol={gdapi.gd_string_to_pystr(&symbol)!r}, path={gdapi.gd_string_to_pystr(&path)!r}, owner=<object 0x{<size_t>owner:x}>)")
-        gd_string_del(&code)
-        gd_string_del(&symbol)
-        gd_string_del(&path)
-        # `gd_object_t` doesn't need to be be deleted (is it just a raw pointer)
         cdef gd_dictionary_t ret = gd_dictionary_new()
         return ret
 
@@ -373,8 +356,6 @@ cdef class PythonScriptLanguage:
         spy_log(f"CALLED PythonScriptLanguage::_make_function(class_name={gdapi.gd_string_to_pystr(&class_name)!r}, function_name={gdapi.gd_string_to_pystr(&function_name)!r}, function_args={function_args!r})")
         cdef object py_class_name = gdapi.gd_string_to_pystr(&class_name)
         cdef object py_function_name = gdapi.gd_string_to_pystr(&function_name)
-        gd_string_del(&class_name)
-        gd_string_del(&function_name)
 
         # Convert function arguments
         cdef object args = []
@@ -385,7 +366,6 @@ cdef class PythonScriptLanguage:
             arg_str = gd_packed_string_array_indexed_getter(&function_args, i)
             args.append(gdapi.gd_string_to_pystr(&arg_str))
             gd_string_del(&arg_str)
-        gd_packed_string_array_del(&function_args)
 
         # Create function signature
         cdef object arg_list = ', '.join(['self'] + args) if args else 'self'
@@ -399,9 +379,6 @@ cdef class PythonScriptLanguage:
         cdef object py_template = gdapi.gd_string_to_pystr(&template)
         cdef object py_class_name = gdapi.gd_string_to_pystr(&class_name)
         cdef object py_base_class_name = gdapi.gd_string_to_pystr(&base_class_name)
-        gd_string_del(&template)
-        gd_string_del(&class_name)
-        gd_string_del(&base_class_name)
 
         # Create a basic Python script template
         cdef object source_template = f'''extends {py_base_class_name}
@@ -427,7 +404,6 @@ class {py_class_name}({py_base_class_name}):
     cdef inline gd_int_t _open_in_external_editor(self, gd_object_t script, gd_int_t line, gd_int_t column):
         # TODO
         spy_log(f"CALLED PythonScriptLanguage::_open_in_external_editor(script=<object 0x{<size_t>script:x}>, line={line}, column={column})")
-        # `gd_object_t` doesn't need to be be deleted (is it just a raw pointer)
         return Error.ERR_UNAVAILABLE
 
     # godot_extension: method(virtual=True)
@@ -479,19 +455,16 @@ class {py_class_name}({py_base_class_name}):
     cdef inline void _reload_scripts(self, gd_array_t scripts, gd_bool_t soft_reload):
         # TODO
         spy_log(f"CALLED PythonScriptLanguage::_reload_scripts(scripts={scripts!r}, soft_reload={soft_reload})")
-        gd_array_del(&scripts)
 
     # godot_extension: method(virtual=True)
     cdef inline void _reload_tool_script(self, gd_object_t script, gd_bool_t soft_reload):
         # TODO
         spy_log(f"CALLED PythonScriptLanguage::_reload_tool_script(script=<object 0x{<size_t>script:x}>, soft_reload={soft_reload})")
-        # `gd_object_t` doesn't need to be be deleted (is it just a raw pointer)
 
     # godot_extension: method(virtual=True)
     cdef inline void _remove_named_global_constant(self, gd_string_name_t name):
         # TODO
         spy_log(f"CALLED PythonScriptLanguage::_remove_named_global_constant(name={gdapi.gd_string_name_to_pystr(&name)!r})")
-        gd_string_name_del(&name)
 
     # godot_extension: method(virtual=True, const=True)
     cdef inline gd_bool_t _supports_builtin_mode(self):
@@ -519,16 +492,13 @@ class {py_class_name}({py_base_class_name}):
         # TODO
         spy_log(f"CALLED PythonScriptLanguage::_validate(script={gdapi.gd_string_to_pystr(&script)!r}, path={gdapi.gd_string_to_pystr(&path)!r}, validate_functions={validate_functions}, validate_errors={validate_errors}, validate_warnings={validate_warnings}, validate_safe_lines={validate_safe_lines})")
         cdef gd_dictionary_t ret = gd_dictionary_new()
-        gd_string_del(&script)
-        gd_string_del(&path)
         return ret
 
     # godot_extension: method(virtual=True, const=True)
     cdef inline gd_string_t _validate_path(self, gd_string_t path):
         # TODO
         spy_log(f"CALLED PythonScriptLanguage::_validate_path(path={gdapi.gd_string_to_pystr(&path)!r})")
         cdef gd_string_t ret = gd_string_from_pybytes(b"")
-        gd_string_del(&path)
         return ret
 
     # godot_extension: generate_class_code()