Skip to content

Conversation

@uni-kakurenbo
Copy link
Contributor

@uni-kakurenbo uni-kakurenbo commented Sep 13, 2025

概要

Cropper.js の新メジャーバージョンです.
公式のデモを見てもわかるように、まだ少々動作が安定していないのでしばらく後続のリリースを待った方がよさそうです.
一旦 draft として PR は立てておきます.

なぜこの PR を入れたいのか

#4735 がそこそこ大規模な変更になりそうだったので PR 立て直しました.

PR を出す前の確認事項

  • (機能の追加なら)追加することの合意がチームで取れている
    • 取れていない場合はチェックを外して PR にすれば OK
  • 動作確認ができている
  • 自分で一度コードを眺めて自分的に問題はなさそう

@uni-kakurenbo uni-kakurenbo added the dependencies Pull requests that update a dependency file label Sep 13, 2025
@github-actions
Copy link

@codecov
Copy link

codecov bot commented Sep 13, 2025

Codecov Report

❌ Patch coverage is 0% with 127 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.49%. Comparing base (c1742f3) to head (7a88f0f).

Files with missing lines Patch % Lines
src/components/Settings/ImageUpload.vue 0.00% 127 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4789      +/-   ##
==========================================
- Coverage   13.52%   13.49%   -0.03%     
==========================================
  Files         708      708              
  Lines       32045    32116      +71     
  Branches      680      680              
==========================================
  Hits         4335     4335              
- Misses      27698    27769      +71     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@uni-kakurenbo uni-kakurenbo force-pushed the feat/update-cropperjs-2.x branch 2 times, most recently from 3ca81f1 to a9f00d0 Compare September 13, 2025 04:24
@uni-kakurenbo uni-kakurenbo self-assigned this Sep 13, 2025
@uni-kakurenbo uni-kakurenbo force-pushed the feat/update-cropperjs-2.x branch from a9f00d0 to 7a88f0f Compare October 31, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants