Skip to content

Commit 84f2025

Browse files
committed
cleanup: remove placeholder comments after removing work_done; no behavior change
1 parent f4b94f7 commit 84f2025

File tree

7 files changed

+3
-8
lines changed

7 files changed

+3
-8
lines changed

crates/cubecl-cuda/src/compute/server.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,6 @@ impl ComputeServer for CudaServer {
544544
Box::pin(self.sync_stream_async())
545545
}
546546

547-
// Completion fences are handled through `sync()`.
548547

549548
fn start_profile(&mut self) -> ProfilingToken {
550549
// Wait for current work to be done.

crates/cubecl-hip/src/compute/server.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,6 @@ impl ComputeServer for HipServer {
318318
Box::pin(self.sync_stream_async())
319319
}
320320

321-
// Completion fences are handled through `sync()`.
322321

323322
fn start_profile(&mut self) -> ProfilingToken {
324323
cubecl_common::future::block_on(self.sync());

crates/cubecl-runtime/src/channel/base.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ pub trait ComputeChannel<Server: ComputeServer>: Clone + core::fmt::Debug + Send
3737
/// Wait for the completion of every task in the server.
3838
fn sync(&self) -> DynFut<()>;
3939

40-
// Completion fences are handled through `sync()`.
4140

4241
/// Given a resource handle, return the storage resource.
4342
fn get_resource(

crates/cubecl-runtime/src/channel/cell.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ where
8585
server.sync()
8686
}
8787

88-
// Completion fences are handled through `sync()`.
88+
8989

9090
fn get_resource(
9191
&self,

crates/cubecl-runtime/src/channel/mpsc.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ where
172172
server.sync().await;
173173
callback.send(()).await.unwrap();
174174
}
175-
// Removed: WorkDone
175+
176176
Message::Flush => {
177177
server.flush();
178178
}
@@ -330,7 +330,7 @@ where
330330
})
331331
}
332332

333-
// Completion fences are handled through `sync()`.
333+
334334

335335
fn memory_usage(&self) -> crate::memory_management::MemoryUsage {
336336
let (callback, response) = async_channel::unbounded();

crates/cubecl-runtime/src/channel/mutex.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ where
7979
server.sync()
8080
}
8181

82-
// Completion fences are handled through `sync()`.
8382

8483
fn get_resource(
8584
&self,

crates/cubecl-wgpu/src/compute/server.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,6 @@ impl ComputeServer for WgpuServer {
199199
self.stream.sync()
200200
}
201201

202-
// Completion fences are handled through `sync()`.
203202

204203
fn start_profile(&mut self) -> ProfilingToken {
205204
self.stream.start_profile()

0 commit comments

Comments
 (0)