Eliminate mutable field anti-patterns and improve error handling #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akanksha-kedia
force-pushed
the
feature/todo1
branch
from
2527228 to
b47c06d
Compare
oneonestar
reviewed
Oct 1, 2025
gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ClusterStatsJdbcMonitor.java
Show resolved
Hide resolved
| this.routingRulesManager = requireNonNull(routingRulesManager, "routingRulesManager is null"); | ||
|
|
||
| // Create immutable copy of UI configuration to ensure thread safety | ||
| this.immutableUiConfiguration = ImmutableUIConfiguration.copyOf(configuration.getUiConfiguration()); |
Member
There was a problem hiding this comment.
I don’t understand the reasoning behind this change.
If UiConfiguration does not change throughout the application’s lifetime, there is no need to copy it, and we won’t have a thread safety problem.
If UiConfiguration can change, this will result in a stale copy.
Akanksha-kedia
force-pushed
the
feature/todo1
branch
2 times, most recently
from
af6555e to
fc1f627
Compare
Akanksha-kedia
force-pushed
the
feature/todo1
branch
from
fc1f627 to
7ff6aa2
Compare
Member
|
Replaced by #777 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
. ClusterStatsJdbcMonitor.java - Complete Immutable Configuration Refactor
Problem: Mutable
Propertiesfield causing potential thread safety issues Solution: Created comprehensive immutable configuration systemNew Files Created:
JdbcMonitorConfiguration.java- Immutable JDBC configuration class with factory methodsKey Changes:
private final Properties propertieswithprivate final JdbcMonitorConfiguration jdbcConfigJdbcMonitorConfiguration.from()for easy constructiontoProperties()method for backward compatibility with JDBC drivers2. GatewayWebAppResource.java - Immutable UI Configuration
Problem: Mutable
UIConfigurationfield in web resource Solution: Created immutable wrapper with defensive copyingNew Files Created:
ImmutableUIConfiguration.java- Thread-safe UI configuration wrapperKey Changes:
private final UIConfiguration uiConfigurationwithprivate final ImmutableUIConfiguration immutableUiConfigurationImmutableUIConfiguration.copyOf()factory methodImmutableListfor collectionsAdditional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required, with the following suggested text:
* Fix some things.