chore: clean code

Author: trongtindev

lib/imports.dart

@@ -34,6 +34,7 @@ export 'package:permission_handler/permission_handler.dart' show Permission;
 export 'package:file_picker/file_picker.dart' show PlatformFile;
 export 'package:flutter_inappwebview/flutter_inappwebview.dart'
     show CookieManager, WebUri, HTTPCookieSameSitePolicy;
+export 'package:url_launcher/url_launcher.dart';
 
 export 'dart:io' show File, Platform;
 export 'dart:async';

lib/l10n/app_en.arb

@@ -81,6 +81,7 @@
   "contacts_empty_description": "Start adding new contacts by clicking on the button below",
   "contacts_add": "Add contact",
   "settings": "Settings",
+  "settings_notification": "Notification",
   "login_title": "Log in to your account",
   "login_description": "You are connected to {base_url}.",
   "@login_description": {
@@ -233,7 +234,8 @@
   "notification_empty_description": "Once you start receiving notifications, they'll appear here.",
   "notification_no_more": "All notifications loaded",
   "notification_mark_all_read": "Mark all as read",
-  "notification_push": "Push Notifications",
+  "notification_type": "Notification type",
+  "notification_push": "Push Notification",
   "notification_create_push": "A new conversation is created",
   "notification_assignee_push": "A conversation is assigned to you",
   "notification_new_message_push": "You are mentioned in a conversation",

lib/layouts/default/default.dart

@@ -33,24 +33,20 @@ class DefaultLayoutController extends GetxController
   }
 }
 
-class DefaultLayout extends GetView<DefaultLayoutController> {
+class DefaultLayout extends StatelessWidget {
   final theme = Get.find<ThemeService>();
+  final controller = Get.put(DefaultLayoutController());
   final conversations = Get.find<ConversationsController>();
   final notifications = Get.find<NotificationsController>();
 
   DefaultLayout({super.key});
 
   @override
   Widget build(BuildContext context) {
-    return GetBuilder(
-      init: DefaultLayoutController(),
-      builder: (_) {
-        if (GetPlatform.isDesktop) {
-          return buildDesktop(context);
-        }
-        return buildMobile(context);
-      },
-    );
+    if (GetPlatform.isDesktop) {
+      return buildDesktop(context);
+    }
+    return buildMobile(context);
   }
 
   Widget buildMobile(BuildContext context) {

lib/screens/agents/controllers/index.dart

@@ -5,6 +5,7 @@ class AgentsController extends GetxController {
   final _logger = Logger();
   final _api = Get.find<ApiService>();
   final _auth = Get.find<AuthService>();
+
   final items = RxList<UserInfo>();
 
   @override

lib/screens/agents/views/index.dart

@@ -1,11 +1,11 @@
 import '/imports.dart';
 
-class AgentsView extends GetView<AgentsController> {
+class AgentsView extends StatelessWidget {
   final auth = Get.find<AuthService>();
   final realtime = Get.find<RealtimeService>();
-  late final AgentsController c;
 
-  AgentsView({super.key}) : c = Get.put(AgentsController());
+  final AgentsController controller;
+  AgentsView({super.key}) : controller = Get.put(AgentsController());
 
   @override
   Widget build(BuildContext context) {
@@ -30,7 +30,7 @@ class AgentsView extends GetView<AgentsController> {
             ),
           ),
           Obx(() {
-            final items = c.items.value;
+            final items = controller.items.value;
 
             return SliverList(
               delegate: SliverChildBuilderDelegate(

lib/screens/audit_logs/views/index.dart

@@ -1,9 +1,9 @@
 import '../controllers/index.dart';
 import '/imports.dart';
 
-class AuditLogsView extends GetView<AuditLogsController> {
-  late final AuditLogsController c;
-  AuditLogsView({super.key}) : c = Get.put(AuditLogsController());
+class AuditLogsView extends StatelessWidget {
+  final AuditLogsController controller;
+  AuditLogsView({super.key}) : controller = Get.put(AuditLogsController());
 
   @override
   Widget build(BuildContext context) {

lib/screens/browser/views/index.dart

@@ -4,11 +4,13 @@ import '/imports.dart';
 
 class BrowserView extends StatelessWidget {
   final BrowserController controller;
-
   BrowserView({
     super.key,
     required String url,
-  }) : controller = Get.put(BrowserController(initialUrl: url), tag: url);
+  }) : controller = Get.put(
+          BrowserController(initialUrl: url),
+          tag: url,
+        );
 
   @override
   Widget build(BuildContext context) {

lib/screens/canned_responses/views/index.dart

@@ -1,10 +1,11 @@
 import '/imports.dart';
 
 class CannedResponsesView extends StatelessWidget {
-  final CannedResponsesController c;
   final auth = Get.find<AuthService>();
 
-  CannedResponsesView({super.key}) : c = Get.find<CannedResponsesController>();
+  final CannedResponsesController controller;
+  CannedResponsesView({super.key})
+      : controller = Get.find<CannedResponsesController>();
 
   @override
   Widget build(BuildContext context) {
@@ -29,7 +30,7 @@ class CannedResponsesView extends StatelessWidget {
             ),
           ),
           Obx(() {
-            final items = c.items.value;
+            final items = controller.items.value;
 
             return SliverList(
               delegate: SliverChildBuilderDelegate(

lib/screens/contacts/controllers/detail.dart

@@ -6,10 +6,10 @@ class ContactDetailController extends GetxController {
   final _api = Get.find<ApiService>();
   final _realtime = Get.find<RealtimeService>();
 
-  final int id;
+  final int contact_id;
 
   ContactDetailController(
-    this.id, {
+    this.contact_id, {
     ContactInfo? initial,
   }) : info = Rxn<ContactInfo>(initial);
 
@@ -41,7 +41,7 @@ class ContactDetailController extends GetxController {
   Future<void> getContact() async {
     try {
       final result = await _api.getContact(
-        contact_id: id,
+        contact_id: contact_id,
         onCacheHit: (data) => info.value = data,
       );
       final data = result.getOrThrow();
@@ -58,7 +58,7 @@ class ContactDetailController extends GetxController {
   Future<void> getLabels() async {
     try {
       final result = await _api.getContactLabels(
-        contact_id: id,
+        contact_id: contact_id,
         onCacheHit: (data) => labels.value = data,
       );
       final data = result.getOrThrow();
@@ -75,7 +75,7 @@ class ContactDetailController extends GetxController {
   Future<void> getConversations() async {
     try {
       final result = await _api.getContactConversations(
-        contact_id: id,
+        contact_id: contact_id,
         onCacheHit: (data) => conversations.value = data,
       );
       final data = result.getOrThrow();
@@ -94,7 +94,7 @@ class ContactDetailController extends GetxController {
     if (items.isEmpty) return;
     labels.value = items.map((e) => e.title).toList();
     await _api.updateContactLabels(
-      contact_id: id,
+      contact_id: contact_id,
       labels: items.map((e) => e.title).toList(),
     );
   }

lib/screens/contacts/views/detail.dart

@@ -1,27 +1,26 @@
-import 'package:url_launcher/url_launcher.dart';
-
 import '../../conversations/widgets/item.dart';
 import '/screens/contacts/controllers/detail.dart';
 import '/imports.dart';
 
 class ContactDetailView extends StatelessWidget {
   final labels = Get.find<LabelsController>();
   final realtime = Get.find<RealtimeService>();
-  final attributeService = Get.find<CustomAttributesController>();
-
-  final ContactDetailController c;
-  final int id;
+  final customAttributes = Get.find<CustomAttributesController>();
 
+  final ContactDetailController controller;
   ContactDetailView({
     super.key,
-    required this.id,
+    required int id,
     ContactInfo? initial,
-  }) : c = Get.put(ContactDetailController(id, initial: initial), tag: '$id');
+  }) : controller = Get.putOrFind(
+          () => ContactDetailController(id, initial: initial),
+          tag: '$id',
+        );
 
   @override
   Widget build(BuildContext context) {
     return Obx(() {
-      final info = c.info.value;
+      final info = controller.info.value;
       if (info == null) {
         return Scaffold(
           appBar: AppBar(),
@@ -89,7 +88,7 @@ class ContactDetailView extends StatelessWidget {
   }
 
   Widget buildActions() {
-    final info = c.info.value;
+    final info = controller.info.value;
 
     return Padding(
       padding: const EdgeInsets.all(4.0),
@@ -132,18 +131,15 @@ class ContactDetailView extends StatelessWidget {
   }) {
     return FilledButton.tonal(
       onPressed: onPressed,
-      child: Column(
-        children: [
-          Padding(
-            padding:
-                const EdgeInsets.only(left: 8, right: 8, top: 8, bottom: 4),
-            child: Icon(iconData),
-          ),
-          Padding(
-            padding: const EdgeInsets.only(left: 8, right: 8, bottom: 8),
-            child: Text(label),
-          ),
-        ],
+      child: Padding(
+        padding: const EdgeInsets.only(top: 8, bottom: 8),
+        child: Column(
+          spacing: 4,
+          children: [
+            Icon(iconData),
+            Text(label),
+          ],
+        ),
       ),
     );
   }
@@ -189,7 +185,7 @@ class ContactDetailView extends StatelessWidget {
 
   Widget buildLabels(BuildContext context) {
     return Obx(() {
-      final items = c.labels.value;
+      final items = controller.labels.value;
 
       return Column(
         crossAxisAlignment: CrossAxisAlignment.start,
@@ -229,7 +225,7 @@ class ContactDetailView extends StatelessWidget {
                 Chip(
                   label: Text(t.modify),
                   deleteIcon: Icon(Icons.edit),
-                  onDeleted: c.modifyLabels,
+                  onDeleted: controller.modifyLabels,
                 )
               ],
             ),
@@ -241,7 +237,7 @@ class ContactDetailView extends StatelessWidget {
 
   Widget buildConversations(BuildContext context) {
     return Obx(() {
-      final items = c.conversations.value;
+      final items = controller.conversations.value;
       if (items.isEmpty) return Container();
 
       return Column(
@@ -310,7 +306,7 @@ class ContactDetailView extends StatelessWidget {
         buildLabel(t.custom_attributes),
         Card(
           child: Obx(() {
-            final attributes = attributeService.items.value;
+            final attributes = customAttributes.items.value;
 
             return ListView.builder(
               padding: EdgeInsets.zero,