Update django.test.runner stubs
#1888
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Dec 23, 2023
| ) -> Iterator[TestCase]: ... | ||
| def reorder_tests( | ||
| tests: list[TestCase], classes: tuple[type[TestCase], ...], reverse: bool = ..., shuffler: Shuffler | None = ... | ||
| ) -> Iterator[TestCase]: ... |
Member
There was a problem hiding this comment.
Why do you use Iterator here and Generator in iter_test_cases? They should be similar
| def run_tests(self, test_labels: list[str], extra_tests: list[Any] | None = ..., **kwargs: Any) -> int: ... | ||
|
|
||
| def is_discoverable(label: str) -> bool: ... | ||
| def try_importing(label: str) -> bool: ... |
Member
There was a problem hiding this comment.
It returns tuple[bool, bool]: https://github.com/django/django/blob/14917c9ae272f47d23401100faa6cefa8e1728bf/django/test/runner.py#L1097
| test_runner: type[TextTestRunner] | ||
| test_loader: TestLoader | ||
| reorder_by: tuple[SimpleTestCase, ...] | ||
| reorder_by: tuple[type[TestCase], type[SimpleTestCase]] |
Member
There was a problem hiding this comment.
I think that it should be tuple[type[X], ...], where X is a proper type name.
Why? Because it would be easier to subclass and change. Or maybe even Iterable / Sequence.
|
|
||
| class ParallelTestSuite(TestSuite): | ||
| init_worker: Any | ||
| process_setup: Callable |
| shouldStop: bool | ||
| testsRun: int | ||
| def __init__(self) -> None: ... | ||
| def __init__(self, *args: Any, **kwargs: Any) -> None: ... |
Member
There was a problem hiding this comment.
Can you please add a TODO entry to sync this signature with unittest.TestResult?
Collaborator
|
Assigned to @sobolevn. If you don't want to lead the review here, feel free to unassign yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes 25 entries form the todolist.
I moved
RemovedInDjangoXXallowlist entries at the bottom of theallowlist.txtso it's easier to find/update them.