-
-
Notifications
You must be signed in to change notification settings - Fork 12
Add Unicode 17 emoji #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I think it would be better to close this for now and re-open it when Unicode 17 actually lands. Unicode 17 also plans to add other characters that we might want to add to Codex (such as arrows), so I tend to think it would be best not to flood the PR list with PRs we know we won't be able to merge for multiple months. |
|
I second this. Unicode 17 won't be out for several months at best. |
|
Now that Unicode 17 has been officially released, we can re-open this PR. |
MDLC01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will also need to update the changelog before merging.
Unicode 17 is still a few months away but I noticed a draft list of the new emoji is already online.
Emoji added
1FAEA distorted face
1FAEF fight cloud
1FAC8 hairy creature
1F9D1 200D 1FA70 ballet dancer
1FACD orca
1F6D8 landslide
1FA8A trombone
1FA8E treasure chest
Some notes:
cloud.fight: Not sure this fits undercloud.whale.orca: Orca or killer whale?rock.slide: Might be better undermountain.money.chest:treasureinstead?Unicode 17 also introduces skin tone variants for ballet dancer, people wrestling, and people with bunny ears, which I haven’t included.