alpin-cv:0.1.0 - #2692
alpin-cv:0.1.0#2692edwin-cox wants to merge 6 commits into
Conversation
typst-package-check
Bot
changed the title
| @@ -0,0 +1,143 @@ | |||
| #import "../package.typ": * | |||
There was a problem hiding this comment.
| #import "../package.typ": * | |
| #import "@preview/alpin-cv:0.1.0": * |
|
|
||
| #show: cv.with( | ||
| theme: theme, | ||
| photo: "photo.png", |
There was a problem hiding this comment.
This will not work as you expect: paths are resolved relatively to where the image function is called. Here, this means inside of the package, not inside of the user's project. Thus, you will only be able to display image files that are part of your package, not a custom image in the project.
The solution to fix that — at least for now — is to pass an image directly as a parameter instead of a path.
More details here
| @@ -0,0 +1,143 @@ | |||
| #import "../package.typ": * | |||
| #import "../common.typ": * | |||
There was a problem hiding this comment.
The contents of this module should be re-exported by your package entrypoint.
There was a problem hiding this comment.
If this image is under a different license as the rest of the code, it would be nice to specify it in the README or some other file. If it is AI-generated, it's best to state so too.
|
Hey, do you think you will have time to finish this PR in the coming days? No worries if not, I'll simply close it then, to keep our review backlog clear. You can re-open a new PR once ready. |
|
Sorry, I need more time before I can work on that again. I'll make a new PR when it's ready. |
2 participants
I am submitting
Description: Personal variant of minimal-cv that is more flexible to customize, closer to natural Typst formatting, and includes tags functionality.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE