Skip to content

Commit 39fe6b7

Browse files
committed
reading constants from plugin and Dockstore API URL as env var
1 parent 301adf5 commit 39fe6b7

File tree

1 file changed

+6
-85
lines changed

1 file changed

+6
-85
lines changed

airflow/dags/appgen_dag.py

Lines changed: 6 additions & 85 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,19 @@
1414
from airflow.providers.cncf.kubernetes.operators.pod import KubernetesPodOperator
1515
from airflow.utils.trigger_rule import TriggerRule
1616
from kubernetes.client import models as k8s
17-
from unity_sps_utils import ( # DEFAULT_LOG_LEVEL,; EC2_TYPES,; POD_LABEL,; build_ec2_type_label,
17+
from unity_sps_utils import (
18+
DEFAULT_LOG_LEVEL,
19+
EC2_TYPES,
1820
NODE_POOL_DEFAULT,
1921
NODE_POOL_HIGH_WORKLOAD,
22+
POD_LABEL,
2023
POD_NAMESPACE,
24+
build_ec2_type_label,
2125
get_affinity,
2226
)
2327

2428
from airflow import DAG
2529

26-
POD_LABEL = "appgen_pod" + datetime.now().strftime(
27-
"%Y%m%d_%H%M%S_%f"
28-
) # unique pod label to assure each job runs on its own pod
29-
3030
CONTAINER_RESOURCES = k8s.V1ResourceRequirements(
3131
requests={
3232
"ephemeral-storage": "{{ params.request_storage }} ",
@@ -38,86 +38,6 @@
3838
DOCKERHUB_TOKEN = "/unity/ads/app_gen/development/dockerhub_api_key"
3939
DOCKSTORE_TOKEN = "/unity/ads/app_gen/development/dockstore_token"
4040

41-
# >>> This part will be removed once the parameters can be imported from unity_sps_plugins.py
42-
DEFAULT_LOG_LEVEL = 20
43-
EC2_TYPES = {
44-
"t3.micro": {
45-
"desc": "General Purpose",
46-
"cpu": 1,
47-
"memory": 1,
48-
},
49-
"t3.small": {
50-
"desc": "General Purpose",
51-
"cpu": 2,
52-
"memory": 2,
53-
},
54-
"t3.medium": {
55-
"desc": "General Purpose",
56-
"cpu": 2,
57-
"memory": 4,
58-
},
59-
"t3.large": {
60-
"desc": "General Purpose",
61-
"cpu": 2,
62-
"memory": 8,
63-
},
64-
"t3.xlarge": {
65-
"desc": "General Purpose",
66-
"cpu": 4,
67-
"memory": 16,
68-
},
69-
"t3.2xlarge": {
70-
"desc": "General Purpose",
71-
"cpu": 8,
72-
"memory": 32,
73-
},
74-
"r7i.xlarge": {
75-
"desc": "Memory Optimized",
76-
"cpu": 4,
77-
"memory": 32,
78-
},
79-
"r7i.2xlarge": {
80-
"desc": "Memory Optimized",
81-
"cpu": 8,
82-
"memory": 64,
83-
},
84-
"r7i.4xlarge": {
85-
"desc": "Memory Optimized",
86-
"cpu": 16,
87-
"memory": 128,
88-
},
89-
"r7i.8xlarge": {
90-
"desc": "Memory Optimized",
91-
"cpu": 32,
92-
"memory": 256,
93-
},
94-
"c6i.xlarge": {
95-
"desc": "Compute Optimized",
96-
"cpu": 4,
97-
"memory": 8,
98-
},
99-
"c6i.2xlarge": {
100-
"desc": "Compute Optimized",
101-
"cpu": 8,
102-
"memory": 16,
103-
},
104-
"c6i.4xlarge": {
105-
"desc": "Compute Optimized",
106-
"cpu": 16,
107-
"memory": 32,
108-
},
109-
"c6i.8xlarge": {
110-
"desc": "Compute Optimized",
111-
"cpu": 32,
112-
"memory": 64,
113-
},
114-
}
115-
116-
117-
def build_ec2_type_label(key):
118-
return f"{key} ({EC2_TYPES.get(key)['desc']}: {EC2_TYPES.get(key)['cpu']}vCPU, {EC2_TYPES.get(key)['memory']}GiB)"
119-
120-
12141
# <<<
12242
LOG_LEVEL_TYPE = {10: "DEBUG", 20: "INFO"}
12343

@@ -177,6 +97,7 @@ def build_ec2_type_label(key):
17797
),
17898
k8s.V1EnvVar(name="DOCKERHUB_TOKEN", value="{{ ti.xcom_pull(task_ids='Setup', key='dockerhub_token') }}"),
17999
k8s.V1EnvVar(name="DOCKSTORE_TOKEN", value="{{ ti.xcom_pull(task_ids='Setup', key='dockstore_token') }}"),
100+
k8s.V1EnvVar(name="DOCKSTORE_API_URL", value="http://awslbdockstorestack-lb-1429770210.us-west-2.elb.amazonaws.com:9998/api"),
180101
k8s.V1EnvVar(name="GITHUB_REPO", value="{{ params.repository }}"),
181102
]
182103

0 commit comments

Comments
 (0)