fix: pnp global cache should be supported (#129)

Windows global cache is still unsupported due to upstream

see also yarnpkg/pnp-rs#10

Author: JounQin

.github/actions/pnpm/action.yml

@@ -32,5 +32,7 @@ runs:
       shell: bash
       run: |
         cd fixtures/pnp
-        corepack enable
+        yarn install
+
+        cd ../global-pnp
         yarn install

Cargo.lock

@@ -84,6 +84,7 @@ document-features = { version = "0.2.11", optional = true }
 
 [dev-dependencies]
 criterion2 = { version = "3.0.0", default-features = false }
+dirs = { version = "6.0.0" }
 normalize-path = { version = "0.2.1" }
 rayon = { version = "1.10.0" }
 vfs = "0.12.1" # for testing with in memory file system

Cargo.toml

@@ -148,7 +148,7 @@ fn bench_resolver(c: &mut Criterion) {
 
     // check validity
     for (path, request) in &data {
-        assert!(unrs_resolver().resolve(path, request).is_ok(), "{path:?} {request}");
+        assert!(unrs_resolver().resolve(path, request).is_ok(), "{:?} {request}", path.display());
     }
 
     let symlink_test_dir = create_symlinks().expect("Create symlink fixtures failed");

benches/resolver.rs

@@ -7,12 +7,12 @@ use unrs_resolver::{AliasValue, ResolveOptions, Resolver};
 fn main() {
     let path = PathBuf::from(env::args().nth(1).expect("path"));
 
-    assert!(path.is_dir(), "{path:?} must be a directory that will be resolved against.");
-    assert!(path.is_absolute(), "{path:?} must be an absolute path.");
+    assert!(path.is_dir(), "{} must be a directory that will be resolved against.", path.display());
+    assert!(path.is_absolute(), "{} must be an absolute path.", path.display());
 
     let specifier = env::args().nth(2).expect("specifier");
 
-    println!("path: {path:?}");
+    println!("path: {}", path.to_string_lossy());
     println!("specifier: {specifier}");
 
     let options = ResolveOptions {
@@ -29,6 +29,6 @@ fn main() {
 
     match Resolver::new(options).resolve(path, &specifier) {
         Err(error) => println!("Error: {error}"),
-        Ok(resolution) => println!("Resolved: {:?}", resolution.full_path()),
+        Ok(resolution) => println!("Resolved: {}", resolution.full_path().display()),
     }
 }

examples/resolver.rs

@@ -0,0 +1,7 @@
+.pnp.*
+.yarn/*
+!.yarn/patches
+!.yarn/plugins
+!.yarn/releases
+!.yarn/sdks
+!.yarn/versions

fixtures/global-pnp/.gitignore

@@ -0,0 +1 @@
+enableGlobalCache: true

fixtures/global-pnp/.yarnrc.yml

@@ -0,0 +1,7 @@
+{
+  "name": "global-pnp",
+  "packageManager": "[email protected]",
+  "dependencies": {
+    "source-map-support": "^0.5.21"
+  }
+}

fixtures/global-pnp/package.json

@@ -0,0 +1 @@
+console.log(require.resolve('source-map-support'))

fixtures/global-pnp/test.js

@@ -0,0 +1,38 @@
+# This file is generated by running "yarn install" inside your project.
+# Manual changes might be lost - proceed with caution!
+
+__metadata:
+  version: 8
+  cacheKey: 10c0
+
+"buffer-from@npm:^1.0.0":
+  version: 1.1.2
+  resolution: "buffer-from@npm:1.1.2"
+  checksum: 10c0/124fff9d66d691a86d3b062eff4663fe437a9d9ee4b47b1b9e97f5a5d14f6d5399345db80f796827be7c95e70a8e765dd404b7c3ff3b3324f98e9b0c8826cc34
+  languageName: node
+  linkType: hard
+
+"global-pnp@workspace:.":
+  version: 0.0.0-use.local
+  resolution: "global-pnp@workspace:."
+  dependencies:
+    source-map-support: "npm:^0.5.21"
+  languageName: unknown
+  linkType: soft
+
+"source-map-support@npm:^0.5.21":
+  version: 0.5.21
+  resolution: "source-map-support@npm:0.5.21"
+  dependencies:
+    buffer-from: "npm:^1.0.0"
+    source-map: "npm:^0.6.0"
+  checksum: 10c0/9ee09942f415e0f721d6daad3917ec1516af746a8120bba7bb56278707a37f1eb8642bde456e98454b8a885023af81a16e646869975f06afc1a711fb90484e7d
+  languageName: node
+  linkType: hard
+
+"source-map@npm:^0.6.0":
+  version: 0.6.1
+  resolution: "source-map@npm:0.6.1"
+  checksum: 10c0/ab55398007c5e5532957cb0beee2368529618ac0ab372d789806f5718123cc4367d57de3904b4e6a4170eb5a0b0f41373066d02ca0735a0c4d75c7d328d3e011
+  languageName: node
+  linkType: hard