chore: Upgrade webpack dependencies to match V23 #15079
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Webpack seems to fail on unknown option with the new version: |
|
at least #9934 should be picked. |
|
Pretty sure we would need to backport 801dd25 first |
|
Most likely. There were some issues with it (can't specifically remember what) and then builds broke so didn't have time to continue. |
|
devserver configuration needs to be updated due to webpack-cli 3 -> 4 update. |
This is compatible with Webpack 5 (cherry picked from commit d890ddf)
|
Kudos, SonarCloud Quality Gate passed!
|
|
Current state: |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Uh, why did the tests pass now? I re-ran them to check the 2.8 build, not this particular PR.. |
|
Kudos, SonarCloud Quality Gate passed!
|
Code reviewed:Seems good to me. Tested the buildwith locally built Flow-server dependency and included it in my custom V14 application. Smoke test
Windows 10
Windows 11
Let me know if more OS/Browser shall be tested. Webpack works nicely it seems to me (from logs): All Startup logs: The only interesting thing is the double startup (after the webpack compilation Spring starts again, maybe it is normal) and the warning messages, but I am not sure if it is related to this change: |
czp13
suggested changes
Apr 27, 2023
There was a problem hiding this comment.
It would be good if a second pair of eyes could double checked the warning messages:
npm WARN While resolving: no-name@undefined
npm WARN Found: [email protected]
npm WARN node_modules/webpack-dev-server
npm WARN dev webpack-dev-server@"4.10.0" from the root project
npm WARN 1 more (webpack-babel-multi-target-plugin)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer webpack-dev-server@"^3.1.0" from [email protected]
npm WARN node_modules/webpack-babel-multi-target-plugin
But as said, smoke test was good, just builds having some warning messages.
|
Tested with Key differences:
Smoke Test on Mac/Chrome worked. Full logs: |
|
I bet double reloads were the bug in some old versions, but were fixed afterwards. To be able to apply this patch, we have to find a commit that fixes the double reload. If it takes a significant efforts, I propose to close this PR. |
|
The peer dependency warning is real as https://github.com/DanielSchaffer/webpack-babel-multi-target-plugin depends on webpack-dev-server 3.x. It is not easy to say though if it would still work with webpack-dev-server 4.x or if there are edge cases where it would fail. |
|
Spring Boot restarts because something on the classpath changed. You can see what by adding to |
|
The webpack-babel-multi-target-plugin project is dead though, with no commits in a couple of years and a webpack 5 PR that was "finished" in 2021 but never merged. So no reason to imagine that it will ever be updated officially for webpack-dev-server 4.x |
|
Thank you vm @Artur- for the insights, additional information, and investigation. I propose in that case to close this PR because:
So let's not switch and use |
|
As we discussed in our daily once more, we close this PR. If anytime in the future
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.