-
Notifications
You must be signed in to change notification settings - Fork 327
turbopack support #1639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
turbopack support #1639
Conversation
🦋 Changeset detectedLatest commit: ca539f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@mattcompiles @askoufis Can anyone take a look at this? This is a pretty important feature for next.js users. Or should we consider the project dead? Last PR was merged in early August, basically no activity from maintainers since then. Not meaning to bash anyone, I know it's thankless work maintaining open source software, but it would be nice to know what we can expect from this project. Thanks in advance! |
A PR was merged in September. Reviews take time and ongoing work is often slow. All current maintainers have professional commitments and/or families. I try to look at PRs when I have spare time/motivation, which is often quite sporadic. I'm currently on holiday, but I intend to make some headway on open PRs and repo maintenance in when I get back in early November. |
|
Thanks for your reply! I was a bit too dramatic, sorry about that. Enjoy your holiday, and let me know if I can help with anything to get this PR going. |
adds turbopack support to
@vanilla-extract/next-pluginturbopack doesn't have any sort of external API yet, so in order to evaluate the contents of our
*.css.tsfiles we need to compile it separately using@vanilla-extract/compiler. To avoid import resolution mismatches, we defer module resolution to turbopack via its webpack-compatible api.we import css using data URI sources
next/fontdoesn't work out of the box because turbopack has custom logic for it, so we transform any modules that use it in a css context to contain static references to the generated font family, style, and weight.we also have to stub several next-only modules to prevent them from accidentally running in rare cases during build, which would obviously fail.
fixes #1367