Merge pull request #8 from MichalZr6/main

Improve detection of translated entries in .ts files

Author: Laserlicht

.github/README.md

@@ -208,7 +208,7 @@ def translation_mod_ratio(translation_mods_translation):
 def get_qt_translations(languages):
     data = {}
 
-    for language in [key for key, value in base_mod_existing(languages).items() if value == True]:
+    for language in get_languages():
         data_type = {}
         for type in ["mapeditor", "launcher"]:
             count_translated = 0
@@ -221,7 +221,17 @@ def get_qt_translations(languages):
                 root = ET.fromstring(tmp_str)
                 for item_context in root.iter('context'):
                     for item_message in item_context.iter('message'):
-                        if list(item_message.iter('translation'))[0].get("type") == None:
+                        translator_comment = item_message.find('translatorcomment')
+                        translation = item_message.find('translation')
+
+                        if (
+                            translation is not None
+                            and (
+                                translation.get("type") is None
+                                or (translator_comment is not None and "AI-generated" in translator_comment.text)
+                                or (translation.text is not None and translation.text.strip() != "")
+                            )
+                        ):
                             count_translated += 1
                         else:
                             count_untranslated += 1

.github/update.py

@@ -23,8 +23,8 @@ This tables shows the current translation progress of VCMI. See [here](https://v
 
 |Tool|belarusian|bulgarian|czech|chinese|finnish|french|german|greek|hungarian|italian|japanese|korean|polish|portuguese|romanian|russian|spanish|swedish|norwegian|turkish|ukrainian|vietnamese|
 | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :---: |
-|[mapeditor](https://github.com/vcmi/vcmi/tree/develop/mapeditor/translation)|$\color{red}{\textsf{0.1 \%}}$|$\color{red}{\textsf{0.1 \%}}$|$\color{orange}{\textsf{82.4 \%}}$|$\color{orange}{\textsf{82.4 \%}}$|$\color{red}{\textsf{0.1 \%}}$|$\color{red}{\textsf{45.1 \%}}$|$\color{green}{\textsf{100.0 \%}}$|$\color{red}{\textsf{0.1 \%}}$|$\color{red}{\textsf{62.5 \%}}$|$\color{red}{\textsf{62.5 \%}}$|$\color{red}{\textsf{0.1 \%}}$|$\color{red}{\textsf{0.1 \%}}$|$\color{orange}{\textsf{83.9 \%}}$|$\color{green}{\textsf{100.0 \%}}$|$\color{red}{\textsf{0.1 \%}}$|$\color{red}{\textsf{49.9 \%}}$|$\color{red}{\textsf{62.5 \%}}$|$\color{red}{\textsf{0.1 \%}}$|$\color{red}{\textsf{0.1 \%}}$|$\color{red}{\textsf{0 \%}}$|$\color{red}{\textsf{19.3 \%}}$|$\color{red}{\textsf{16.1 \%}}$|
-|[launcher](https://github.com/vcmi/vcmi/tree/develop/launcher/translation)|$\color{red}{\textsf{0.3 \%}}$|$\color{red}{\textsf{0.3 \%}}$|$\color{green}{\textsf{100.0 \%}}$|$\color{green}{\textsf{100.0 \%}}$|$\color{red}{\textsf{0.3 \%}}$|$\color{green}{\textsf{94.4 \%}}$|$\color{green}{\textsf{100.0 \%}}$|$\color{red}{\textsf{0.3 \%}}$|$\color{green}{\textsf{93.3 \%}}$|$\color{green}{\textsf{93.3 \%}}$|$\color{red}{\textsf{0.3 \%}}$|$\color{red}{\textsf{0.3 \%}}$|$\color{green}{\textsf{94.4 \%}}$|$\color{green}{\textsf{100.0 \%}}$|$\color{red}{\textsf{0.3 \%}}$|$\color{green}{\textsf{94.4 \%}}$|$\color{green}{\textsf{93.3 \%}}$|$\color{green}{\textsf{100.0 \%}}$|$\color{red}{\textsf{0.3 \%}}$|$\color{red}{\textsf{0 \%}}$|$\color{green}{\textsf{94.4 \%}}$|$\color{orange}{\textsf{79.3 \%}}$|
+|[mapeditor](https://github.com/vcmi/vcmi/tree/develop/mapeditor/translation)|$\color{orange}{\textsf{89.5 \%}}$|$\color{orange}{\textsf{88.5 \%}}$|$\color{orange}{\textsf{89.3 \%}}$|$\color{orange}{\textsf{89.8 \%}}$|$\color{orange}{\textsf{89.8 \%}}$|$\color{orange}{\textsf{89.4 \%}}$|$\color{green}{\textsf{100.0 \%}}$|$\color{orange}{\textsf{88.2 \%}}$|$\color{orange}{\textsf{89.4 \%}}$|$\color{orange}{\textsf{89.4 \%}}$|$\color{orange}{\textsf{88.5 \%}}$|$\color{orange}{\textsf{85.8 \%}}$|$\color{orange}{\textsf{89.9 \%}}$|$\color{green}{\textsf{100.0 \%}}$|$\color{orange}{\textsf{88.2 \%}}$|$\color{orange}{\textsf{89.4 \%}}$|$\color{orange}{\textsf{89.4 \%}}$|$\color{orange}{\textsf{88.6 \%}}$|$\color{orange}{\textsf{88.7 \%}}$|$\color{orange}{\textsf{88.5 \%}}$|$\color{orange}{\textsf{88.6 \%}}$|$\color{orange}{\textsf{88.7 \%}}$|
+|[launcher](https://github.com/vcmi/vcmi/tree/develop/launcher/translation)|$\color{red}{\textsf{0.3 \%}}$|$\color{red}{\textsf{0.3 \%}}$|$\color{green}{\textsf{100.0 \%}}$|$\color{green}{\textsf{100.0 \%}}$|$\color{red}{\textsf{0.3 \%}}$|$\color{green}{\textsf{95.0 \%}}$|$\color{green}{\textsf{100.0 \%}}$|$\color{red}{\textsf{0.3 \%}}$|$\color{green}{\textsf{95.0 \%}}$|$\color{green}{\textsf{95.0 \%}}$|$\color{red}{\textsf{0.3 \%}}$|$\color{red}{\textsf{0.3 \%}}$|$\color{green}{\textsf{95.0 \%}}$|$\color{green}{\textsf{100.0 \%}}$|$\color{red}{\textsf{0.3 \%}}$|$\color{green}{\textsf{95.0 \%}}$|$\color{green}{\textsf{95.0 \%}}$|$\color{green}{\textsf{100.0 \%}}$|$\color{red}{\textsf{0.3 \%}}$|$\color{red}{\textsf{0.3 \%}}$|$\color{green}{\textsf{95.0 \%}}$|$\color{green}{\textsf{94.4 \%}}$|
 
 ## Mods translation status