Prevent empty exec

Steveorevo · Steveorevo · commit b3b73dafa786 · 2023-07-20T17:00:03.000-07:00
diff --git a/nodeapp.php b/nodeapp.php
@@ -40,7 +40,7 @@ public function hcpp_runuser( $cmd ) {
         /**
          * Check if system has rebooted and restart apps
          */
-        public function hcpp_rebooted( $args ) {
+        public function hcpp_rebooted() {
 
             // Restart all PM2 apps for all user accounts
             $users = scandir('/home');
@@ -60,7 +60,10 @@ public function hcpp_rebooted( $args ) {
                     $cmd .= 'export NVM_DIR=/opt/nvm && source /opt/nvm/nvm.sh && pm2 resurrect"' . "\n";
                 }
             }
-            shell_exec( $hcpp->do_action( 'nodeapp_resurrect_apps', $cmd ) );
+            $cmd = $hcpp->do_action( 'nodeapp_resurrect_apps', $cmd );
+            if ( trim( $cmd ) != '' )  {
+                $hcpp->log( shell_exec( $cmd ) );
+            }
         }
 
         /**

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public function hcpp_runuser( $cmd ) {`
`40`	`40`	`/**`
`41`	`41`	`* Check if system has rebooted and restart apps`
`42`	`42`	`*/`
`43`		`- public function hcpp_rebooted( $args ) {`
	`43`	`+ public function hcpp_rebooted() {`
`44`	`44`
`45`	`45`	`// Restart all PM2 apps for all user accounts`
`46`	`46`	`$users = scandir('/home');`
`@@ -60,7 +60,10 @@ public function hcpp_rebooted( $args ) {`
`60`	`60`	`$cmd .= 'export NVM_DIR=/opt/nvm && source /opt/nvm/nvm.sh && pm2 resurrect"' . "\n";`
`61`	`61`	`}`
`62`	`62`	`}`
`63`		`- shell_exec( $hcpp->do_action( 'nodeapp_resurrect_apps', $cmd ) );`
	`63`	`+ $cmd = $hcpp->do_action( 'nodeapp_resurrect_apps', $cmd );`
	`64`	`+ if ( trim( $cmd ) != '' ) {`
	`65`	`+ $hcpp->log( shell_exec( $cmd ) );`
	`66`	`+ }`
`64`	`67`	`}`
`65`	`68`
`66`	`69`	`/**`