Add prettier as a default formatter (#1353)

 - Add config
 - Add npm script to check and reformat code
 - Add format check step to GitLab PR pipeline
 - Add .prettierignore
 - Reformat all files

Author: w666

.github/workflows/pr.yml

@@ -13,3 +13,4 @@ jobs:
       - run: npm run build
       - run: npm run lint
       - run: npm run cover
+      - run: npm run format:check

.prettierignore

@@ -0,0 +1,9 @@
+**/*.yml
+**/*.yaml
+.github/
+.nyc_output/
+node_modules/
+lib/
+coverage/
+.vscode/
+.jshintrc

.prettierrc

@@ -0,0 +1,21 @@
+{
+  "arrowParens": "always",
+  "bracketSameLine": false,
+  "bracketSpacing": true,
+  "semi": true,
+  "experimentalTernaries": false,
+  "singleQuote": true,
+  "jsxSingleQuote": true,
+  "quoteProps": "consistent",
+  "trailingComma": "all",
+  "singleAttributePerLine": false,
+  "htmlWhitespaceSensitivity": "css",
+  "vueIndentScriptAndStyle": false,
+  "proseWrap": "preserve",
+  "insertPragma": false,
+  "requirePragma": false,
+  "tabWidth": 2,
+  "useTabs": false,
+  "embeddedLanguageFormatting": "auto",
+  "printWidth": 240
+}

CONTRIBUTING.md

@@ -1,52 +1,60 @@
 # Contribution Guidelines
 
-Thank you for your support!  node-soap wouldn't be where it is today without contributors like you who are willing to take the time to improve it for everyone else.
+Thank you for your support! node-soap wouldn't be where it is today without contributors like you who are willing to take the time to improve it for everyone else.
 
-Because SOAP Web Services can differ amongst implementations, there is high risk involved in making changes.  What works for your WSDL, might not work with another.  It is therefore _essential_ that contributors to node-soap adhere to these guidelines.
+Because SOAP Web Services can differ amongst implementations, there is high risk involved in making changes. What works for your WSDL, might not work with another. It is therefore _essential_ that contributors to node-soap adhere to these guidelines.
 
 ## Submitting a Pull Request
-* Pull Requests **must be rebased to the latest version of master and _squashed to a single commit_** i.e. `git checkout master;git pull upstream master;git checkout feature-branch;git rebase -i master`
-* Pull Requests **must have accompanying tests** (either Unit or Request/Response Sample tests are welcome). Your chances of getting the PR merged are very low if you don't provide any tests.
-* Pull Requests must have passing travis builds.
-* Pull Requests must be able to merge automatically from github.
-* Please **do not close a pull request due to a request to rebase**.  Git is a powerful VCS and deserves your time in learning how to rebase properly.  Pull Requests are updated automatically on github when you force push to your branch after rebasing.
+
+- Pull Requests **must be rebased to the latest version of master and _squashed to a single commit_** i.e. `git checkout master;git pull upstream master;git checkout feature-branch;git rebase -i master`
+- Pull Requests **must have accompanying tests** (either Unit or Request/Response Sample tests are welcome). Your chances of getting the PR merged are very low if you don't provide any tests.
+- Pull Requests must have passing travis builds.
+- Pull Requests must be able to merge automatically from github.
+- Please **do not close a pull request due to a request to rebase**. Git is a powerful VCS and deserves your time in learning how to rebase properly. Pull Requests are updated automatically on github when you force push to your branch after rebasing.
 
 Very useful articles/help on this topic:
-  - [GitHub Help - About Git rebase](https://help.github.com/articles/about-git-rebase/)
-  - [GitHub Help - Using Git rebase](https://help.github.com/articles/using-git-rebase/)
 
-* Please use descriptive commit messages.  Commit messages are used during the creation of history and release notes.  You'll make the job of maintainers much easier by doing this.
+- [GitHub Help - About Git rebase](https://help.github.com/articles/about-git-rebase/)
+- [GitHub Help - Using Git rebase](https://help.github.com/articles/using-git-rebase/)
+
+* Please use descriptive commit messages. Commit messages are used during the creation of history and release notes. You'll make the job of maintainers much easier by doing this.
 
 ## Making Changes
-* Any and all pull requests to change documentation or typos are welcome!
-* Any WSDL checked in should be as small and as generic as possible.  This is to keep the size of the codebase from growing too large and to keep the reason for submitting the WSDL clear I.E. if the WSDL was submitted because attributes were not being parsed on response XML, then it would be appropriate to submit a WSDL that defines a response with attributes *and nothing else*.  If you find an issue with the parser not being able to handle large WSDLs, then it would be appropriate to submit a large WSDL to recreate the issue with.
-* If your Pull Request is WSDL related:
-````
+
+- Any and all pull requests to change documentation or typos are welcome!
+- Any WSDL checked in should be as small and as generic as possible. This is to keep the size of the codebase from growing too large and to keep the reason for submitting the WSDL clear I.E. if the WSDL was submitted because attributes were not being parsed on response XML, then it would be appropriate to submit a WSDL that defines a response with attributes _and nothing else_. If you find an issue with the parser not being able to handle large WSDLs, then it would be appropriate to submit a large WSDL to recreate the issue with.
+- If your Pull Request is WSDL related:
+
+```
     1. Make your WSDL as generic as possible to recreate the issue
     2. Add the WSDL to the appropriate path in test/wsdl.
     3. Commit your changes to a feature branch within your fork.
     4. Issue a pull request.
-````
+```
 
-* If your Pull Request is client related:
-````
+- If your Pull Request is client related:
+
+```
     1. Capture the request / response XML via client.lastRequest and client.lastResponse as well as the WSDL.
     2. Make the WSDL, request, and response XML as generic as possible.
     3. Only include the messages or operations that are having issues.
     4. Add the appropriate files to test/request-response-samples (see the README therein)
     5. Commit your changes to a feature branch within your fork.
     6. Issue a pull request
-````
+```
+
+- If your Pull Request is neither WSDL nor client related:
 
-* If your Pull Request is neither WSDL nor client related:
-````
+```
     1. Provide a test of some form in an appropriate *-test.js file under test/
     2. Commit your changes to a feature branch within your fork.
     3. Issue a pull request.
-````
+```
 
 ## Issue Expiration
-Any pull request filed is subject to an expiration date. We will close any open Pull Request that has not received a response within a 2 week timeframe.  The goal is not to sweep dirt under the rug, but to keep the focus on merging in pull requests.  Please provide pull requests that meet the above criteria wherever possible.
+
+Any pull request filed is subject to an expiration date. We will close any open Pull Request that has not received a response within a 2 week timeframe. The goal is not to sweep dirt under the rug, but to keep the focus on merging in pull requests. Please provide pull requests that meet the above criteria wherever possible.
 
 ## Other ways you can contribute
-Please add response, request, and WSDL files to test/wsdl, and test/request-response-samples (see README therein).  Doing so documents behavior and reduces the likelihood that bugs will be introduced by future pull requests.
+
+Please add response, request, and WSDL files to test/wsdl, and test/request-response-samples (see README therein). Doing so documents behavior and reduces the likelihood that bugs will be introduced by future pull requests.

PUBLISHING.md

@@ -1,28 +1,33 @@
-Publishing
-===================
+# Publishing
 
 This document describes the steps a maintainer of this project generally takes in
 order to publish a newer version of `node-soap`.
 
 ## Ideals
-* Pull Requests that alter, add, or correct functionality have a single commit.
-* All commit messages are descriptive.
-* Maintainers spend little time looking at git history to update HISTORY.md.
+
+- Pull Requests that alter, add, or correct functionality have a single commit.
+- All commit messages are descriptive.
+- Maintainers spend little time looking at git history to update HISTORY.md.
 
 ## Process
-1. Checkout the commit that you would like to publish.  This is usually accomplished
+
+1. Checkout the commit that you would like to publish. This is usually accomplished
    with `git checkout master`.
 2. Run `git log --oneline`
 3. Copy the commit messages above the last release commit message into History.md.
 4. Consolidate the commit messages:
-  * Remove any futile commits I.E. "Removing white space"
-  * Remove Pull Request merge commits.  In some cases, you may need to reference the issue in
-    order to get the commit message for that Pull Request.
-  * Prefix commit messages with "Enhancement", "Fixed", "Deprecated" and so forth
-    accordingly.
-  * Reword line items as necessary.
+
+- Remove any futile commits I.E. "Removing white space"
+- Remove Pull Request merge commits. In some cases, you may need to reference the issue in
+  order to get the commit message for that Pull Request.
+- Prefix commit messages with "Enhancement", "Fixed", "Deprecated" and so forth
+  accordingly.
+- Reword line items as necessary.
+
 5. Update package.json to the appropriate version for the release.
 6. Commit your changes to master and push them up to github.
 7. Use the github interface to create a tag.
-  * Use existing release notes as a reference when adding the release notes to github.
+
+- Use existing release notes as a reference when adding the release notes to github.
+
 8. `npm publish`.