refactor

Author: waynzh

lib/rules/no-reserved-component-names.js

@@ -34,19 +34,6 @@ function isLowercase(word) {
   return /^[a-z]*$/.test(word)
 }
 
-const RESERVED_NAMES_IN_HTML = new Set([
-  ...htmlElements,
-  ...htmlElements.map(casing.capitalize)
-])
-const RESERVED_NAMES_IN_OTHERS = new Set([
-  ...deprecatedHtmlElements,
-  ...deprecatedHtmlElements.map(casing.capitalize),
-  ...kebabCaseElements,
-  ...kebabCaseElements.map(casing.pascalCase),
-  ...svgElements,
-  ...svgElements.filter(isLowercase).map(casing.capitalize)
-])
-
 /**
  * @param {Expression | SpreadElement} node
  * @returns {node is (Literal | TemplateLiteral)}
@@ -114,6 +101,13 @@ module.exports = {
       options.disallowVue3BuiltInComponents === true
     const htmlElementCaseSensitive = options.htmlElementCaseSensitive === true
 
+    const RESERVED_NAMES_IN_HTML = new Set(htmlElements)
+    const RESERVED_NAMES_IN_OTHERS = new Set([
+      ...deprecatedHtmlElements,
+      ...kebabCaseElements,
+      ...svgElements
+    ])
+
     if (!htmlElementCaseSensitive) {
       addAll(RESERVED_NAMES_IN_HTML, htmlElements.map(casing.capitalize))
       addAll(RESERVED_NAMES_IN_OTHERS, [
@@ -130,6 +124,17 @@ module.exports = {
       ...RESERVED_NAMES_IN_OTHERS
     ])
 
+    /**
+     * @param {string} name
+     * @returns {string}
+     */
+    function getMessageId(name) {
+      if (RESERVED_NAMES_IN_HTML.has(name)) return 'reservedInHtml'
+      if (RESERVED_NAMES_IN_VUE.has(name)) return 'reservedInVue'
+      if (RESERVED_NAMES_IN_VUE3.has(name)) return 'reservedInVue3'
+      return 'reserved'
+    }
+
     /**
      * @param {Literal | TemplateLiteral} node
      */
@@ -146,17 +151,6 @@ module.exports = {
       }
     }
 
-    /**
-     * @param {string} name
-     * @returns {string}
-     */
-    function getMessageId(name) {
-      if (RESERVED_NAMES_IN_HTML.has(name)) return 'reservedInHtml'
-      if (RESERVED_NAMES_IN_VUE.has(name)) return 'reservedInVue'
-      if (RESERVED_NAMES_IN_VUE3.has(name)) return 'reservedInVue3'
-      return 'reserved'
-    }
-
     /**
      * @param {ESNode} node
      * @param {string} name

tests/lib/rules/no-reserved-component-names.js

@@ -410,12 +410,16 @@ const invalidElements = [
   'xmp',
   'Xmp'
 ]
-const invalidLowerCaseElements = invalidElements.filter(
-  (element) => element === element.toLowerCase()
-)
-const invalidUpperCaseElements = invalidElements.filter(
-  (element) => element === element.toUpperCase()
-)
+const invalidLowerCaseElements = []
+const invalidUpperCaseElements = []
+
+for (const element of invalidElements) {
+  if (element[0] === element[0].toLowerCase()) {
+    invalidLowerCaseElements.push(element)
+  } else {
+    invalidUpperCaseElements.push(element)
+  }
+}
 
 const vue2BuiltInComponents = [
   'component',