Coverage and readme updates

Author: cardil

README.md

@@ -7,9 +7,10 @@ HTTP/S Java Checker - It can check is your Java installation can perform connect
 ## Debian/Ubuntu
 
 ```bash
-dpkg -i jhttps-checker_0.8.0.deb
-jhttps-checker --help
-usage: jhttps-checker [-h] [-q QUIET] [-r MAX_REDIRECTS] address
+$ wget -O jhttps-checker_0.8.0.deb http://search.maven.org/remotecontent?filepath=pl/wavesoftware/jhttps-checker/0.8.0/jhttps-checker-0.8.0.deb
+$ sudo dpkg -i jhttps-checker-0.8.0.deb
+$ jhttps-checker --help
+usage: jhttps-checker [-h] [-q] [-r MAX_REDIRECTS] address
 
 It can check is your Java installation can perform connection with given HTTPS address
 
@@ -18,8 +19,7 @@ positional arguments:
 
 optional arguments:
   -h, --help             show this help message and exit
-  -q QUIET, --quiet QUIET
-                         Do not display anything, only retcodes (default: false)
+  -q, --quiet            Do not display anything, only retcodes (default: false)
   -r MAX_REDIRECTS, --max_redirects MAX_REDIRECTS
                          Number of redirects to perform at maximum (default: 10)
 ```

src/main/java/pl/wavesoftware/utils/https/checker/logic/MainApplication.java

@@ -24,6 +24,7 @@
 import java.net.URLConnection;
 import java.util.List;
 import java.util.Map;
+import javax.net.ssl.SSLException;
 import pl.wavesoftware.utils.https.checker.cli.Application;
 import pl.wavesoftware.utils.https.checker.cli.Cli.Arguments;
 import pl.wavesoftware.utils.https.checker.cli.Cli.Retcodes;
@@ -53,14 +54,14 @@ public Result perform(ProcessIO pio) {
             io.out("Response OK?: " + response.isSuccessful());
             io.out("------");
             printHeaders(io, response);
-            if (response.isSuccessful()) {
-                result = Result.result(Retcodes.OK);
-            } else {
-                result = Result.result(Retcodes.BAD_SSL);
-            }
+            result = Result.result(Retcodes.OK);
+
         } catch (MalformedURLException ex) {
             io.exception(ex);
             result = Result.result(Retcodes.INVALID_ARGS);
+        } catch (SSLException ex) {
+            io.exception(ex);
+            result = Result.result(Retcodes.BAD_SSL);
         } catch (IOException ex) {
             io.exception(ex);
             result = Result.result(Retcodes.NO_CONNECTION);

src/test/java/pl/wavesoftware/utils/https/checker/HttpsCheckerMainTest.java

@@ -49,6 +49,26 @@ public void testDoMain() {
         result = HttpsCheckerMain.doMain(args);
         assertNotNull(args);
         assertEquals(Result.result(Cli.Retcodes.INVALID_ARGS).retcode(), result.retcode());
+
+        args = new String[]{"httttp://invalid.addres.com/quoa"};
+        result = HttpsCheckerMain.doMain(args);
+        assertNotNull(args);
+        assertEquals(Result.result(Cli.Retcodes.INVALID_ARGS).retcode(), result.retcode());
+
+        args = new String[]{"https://invalid.addres.org/quoa"};
+        result = HttpsCheckerMain.doMain(args);
+        assertNotNull(args);
+        assertEquals(Result.result(Cli.Retcodes.NO_CONNECTION).retcode(), result.retcode());
+
+        args = new String[]{"https://www.google.pl/no-a-file-to-download.txt"};
+        result = HttpsCheckerMain.doMain(args);
+        assertNotNull(args);
+        assertEquals(Result.result(Cli.Retcodes.NO_CONNECTION).retcode(), result.retcode());
+
+        args = new String[]{"https://tv.eurosport.com/"};
+        result = HttpsCheckerMain.doMain(args);
+        assertNotNull(args);
+        assertEquals(Result.result(Cli.Retcodes.BAD_SSL).retcode(), result.retcode());
     }
 
 }