Skip to content

Commit 57fe847

Browse files
svenzikmrts
authored andcommitted
feat: Add configuration parameter ocsp-request-timeout
WE2-1113 Signed-off-by: Sven Mitt <[email protected]>
1 parent c0ba061 commit 57fe847

File tree

2 files changed

+18
-8
lines changed

2 files changed

+18
-8
lines changed

example/src/main/java/eu/webeid/example/config/ValidationConfiguration.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,7 @@ public ChallengeNonceGenerator generator(ChallengeNonceStore challengeNonceStore
7777
.build();
7878
}
7979

80-
@Bean
81-
public X509Certificate[] loadTrustedCACertificatesFromCerFiles() {
80+
private X509Certificate[] loadTrustedCACertificatesFromCerFiles() {
8281
List<X509Certificate> caCertificates = new ArrayList<>();
8382

8483
try {
@@ -99,8 +98,7 @@ public X509Certificate[] loadTrustedCACertificatesFromCerFiles() {
9998
return caCertificates.toArray(new X509Certificate[0]);
10099
}
101100

102-
@Bean
103-
public X509Certificate[] loadTrustedCACertificatesFromTrustStore() {
101+
private X509Certificate[] loadTrustedCACertificatesFromTrustStore(YAMLConfig yamlConfig) {
104102
List<X509Certificate> caCertificates = new ArrayList<>();
105103

106104
try (InputStream is = ValidationConfiguration.class.getResourceAsStream(CERTS_RESOURCE_PATH + activeProfile + "/" + TRUSTED_CERTIFICATES_JKS)) {
@@ -109,7 +107,7 @@ public X509Certificate[] loadTrustedCACertificatesFromTrustStore() {
109107
return new X509Certificate[0];
110108
}
111109
KeyStore keystore = KeyStore.getInstance(KeyStore.getDefaultType());
112-
keystore.load(is, yamlConfig().getTrustStorePassword().toCharArray());
110+
keystore.load(is, yamlConfig.getTrustStorePassword().toCharArray());
113111
Enumeration<String> aliases = keystore.aliases();
114112
while (aliases.hasMoreElements()) {
115113
String alias = aliases.nextElement();
@@ -124,12 +122,13 @@ public X509Certificate[] loadTrustedCACertificatesFromTrustStore() {
124122
}
125123

126124
@Bean
127-
public AuthTokenValidator validator() {
125+
public AuthTokenValidator validator(YAMLConfig yamlConfig) {
128126
try {
129127
return new AuthTokenValidatorBuilder()
130-
.withSiteOrigin(URI.create(yamlConfig().getLocalOrigin()))
128+
.withSiteOrigin(URI.create(yamlConfig.getLocalOrigin()))
131129
.withTrustedCertificateAuthorities(loadTrustedCACertificatesFromCerFiles())
132-
.withTrustedCertificateAuthorities(loadTrustedCACertificatesFromTrustStore())
130+
.withTrustedCertificateAuthorities(loadTrustedCACertificatesFromTrustStore(yamlConfig))
131+
.withOcspRequestTimeout(yamlConfig.getOcspRequestTimeout())
133132
.build();
134133
} catch (JceException e) {
135134
throw new RuntimeException("Error building the Web eID auth token validator.", e);

example/src/main/java/eu/webeid/example/config/YAMLConfig.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
package eu.webeid.example.config;
2424

25+
import java.time.Duration;
2526
import org.springframework.beans.factory.annotation.Value;
2627
import org.springframework.boot.context.properties.ConfigurationProperties;
2728
import org.springframework.boot.context.properties.EnableConfigurationProperties;
@@ -41,6 +42,8 @@ public class YAMLConfig {
4142
@Value("truststore-password")
4243
private String trustStorePassword;
4344

45+
private Duration ocspRequestTimeout = Duration.ofSeconds(5L);
46+
4447
@Value("#{new Boolean('${web-eid-auth-token.validation.use-digidoc4j-prod-configuration}'.trim())}")
4548
private Boolean useDigiDoc4jProdConfiguration;
4649

@@ -75,4 +78,12 @@ public boolean getUseDigiDoc4jProdConfiguration() {
7578
public void setUseDigiDoc4jProdConfiguration(boolean useDigiDoc4jProdConfiguration) {
7679
this.useDigiDoc4jProdConfiguration = useDigiDoc4jProdConfiguration;
7780
}
81+
82+
public Duration getOcspRequestTimeout() {
83+
return ocspRequestTimeout;
84+
}
85+
86+
public void setOcspRequestTimeout(Duration ocspRequestTimeout) {
87+
this.ocspRequestTimeout = ocspRequestTimeout;
88+
}
7889
}

0 commit comments

Comments
 (0)