From 841232e7e8d93f2978128c2933bba61c54857243 Mon Sep 17 00:00:00 2001 From: pshu Date: Fri, 10 Oct 2025 00:57:37 +0800 Subject: [PATCH 1/4] chore: skip window native watcher flaky test --- .../chunks/dynamic-entry-with-depend-on/test.filter.js | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 tests/rspack-test/watchCases/chunks/dynamic-entry-with-depend-on/test.filter.js diff --git a/tests/rspack-test/watchCases/chunks/dynamic-entry-with-depend-on/test.filter.js b/tests/rspack-test/watchCases/chunks/dynamic-entry-with-depend-on/test.filter.js new file mode 100644 index 000000000000..9f877f700318 --- /dev/null +++ b/tests/rspack-test/watchCases/chunks/dynamic-entry-with-depend-on/test.filter.js @@ -0,0 +1,8 @@ +module.exports = function (config) { + let nativeWatcherEnabled = config.experiments?.nativeWatcher === true; + + if (process.platform === "win32" && nativeWatcherEnabled) { + return false + } + return true; +} \ No newline at end of file From 434fffa3c1ef97b5c3cb281ce751f3849b8fd81e Mon Sep 17 00:00:00 2001 From: pshu Date: Fri, 10 Oct 2025 00:58:14 +0800 Subject: [PATCH 2/4] chore: skip flaky e2e test --- tests/e2e/cases/lazy-compilation/persistent-cache/index.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/e2e/cases/lazy-compilation/persistent-cache/index.test.ts b/tests/e2e/cases/lazy-compilation/persistent-cache/index.test.ts index e10ce2ba6d15..e20d8e7e3857 100644 --- a/tests/e2e/cases/lazy-compilation/persistent-cache/index.test.ts +++ b/tests/e2e/cases/lazy-compilation/persistent-cache/index.test.ts @@ -1,6 +1,6 @@ import { expect, test } from "@/fixtures"; -test("should load success", async ({ page, rspack }) => { +test.skip("should load success", async ({ page, rspack }) => { await page.getByText("Click me").click(); let component_count = await page.getByText("Component").count(); expect(component_count).toBe(1); From 773e6d3fce34a99f234086dcb72d38b142138b8a Mon Sep 17 00:00:00 2001 From: pshu Date: Fri, 10 Oct 2025 10:08:41 +0800 Subject: [PATCH 3/4] Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .../chunks/dynamic-entry-with-depend-on/test.filter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/rspack-test/watchCases/chunks/dynamic-entry-with-depend-on/test.filter.js b/tests/rspack-test/watchCases/chunks/dynamic-entry-with-depend-on/test.filter.js index 9f877f700318..8922edee8076 100644 --- a/tests/rspack-test/watchCases/chunks/dynamic-entry-with-depend-on/test.filter.js +++ b/tests/rspack-test/watchCases/chunks/dynamic-entry-with-depend-on/test.filter.js @@ -2,7 +2,7 @@ module.exports = function (config) { let nativeWatcherEnabled = config.experiments?.nativeWatcher === true; if (process.platform === "win32" && nativeWatcherEnabled) { - return false + return false; } return true; } \ No newline at end of file From 87002a157f7c315f94b8866752b8a3366603e50f Mon Sep 17 00:00:00 2001 From: pshu Date: Fri, 10 Oct 2025 10:19:50 +0800 Subject: [PATCH 4/4] chore: add issue refs --- tests/e2e/cases/lazy-compilation/persistent-cache/index.test.ts | 1 + .../chunks/dynamic-entry-with-depend-on/test.filter.js | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/e2e/cases/lazy-compilation/persistent-cache/index.test.ts b/tests/e2e/cases/lazy-compilation/persistent-cache/index.test.ts index e20d8e7e3857..48b86e9faf07 100644 --- a/tests/e2e/cases/lazy-compilation/persistent-cache/index.test.ts +++ b/tests/e2e/cases/lazy-compilation/persistent-cache/index.test.ts @@ -1,5 +1,6 @@ import { expect, test } from "@/fixtures"; +// Ref: https://github.com/web-infra-dev/rspack/issues/11829 test.skip("should load success", async ({ page, rspack }) => { await page.getByText("Click me").click(); let component_count = await page.getByText("Component").count(); diff --git a/tests/rspack-test/watchCases/chunks/dynamic-entry-with-depend-on/test.filter.js b/tests/rspack-test/watchCases/chunks/dynamic-entry-with-depend-on/test.filter.js index 9f877f700318..673f5cc0e116 100644 --- a/tests/rspack-test/watchCases/chunks/dynamic-entry-with-depend-on/test.filter.js +++ b/tests/rspack-test/watchCases/chunks/dynamic-entry-with-depend-on/test.filter.js @@ -1,6 +1,7 @@ module.exports = function (config) { let nativeWatcherEnabled = config.experiments?.nativeWatcher === true; + // Ref: https://github.com/web-infra-dev/rspack/issues/11828 if (process.platform === "win32" && nativeWatcherEnabled) { return false }