feat: new browsers and universal presets

Author: alexander-akait

configs.js

@@ -288,7 +288,9 @@ const typescriptConfig = getTypescriptConfig();
 const reactConfig = getReactConfig();
 const jestConfig = getJestConfig();
 
-configs.recommended = [
+// TODO remove old alises (not started with `node-`) in the next major release
+
+const recommended = [
 	globalIgnores(ignorePaths),
 	isModule
 		? configs["node/mixed-module-and-commonjs"]
@@ -303,7 +305,10 @@ configs.recommended = [
 	configs["package-json/recommended"],
 ];
 
-configs["recommended-module"] = [
+configs.recommended = recommended;
+configs["node-recommended"] = recommended;
+
+const nodeRecommendedModule = [
 	globalIgnores(ignorePaths),
 	configs["node/mixed-module-and-commonjs"],
 	javascriptConfig,
@@ -316,7 +321,10 @@ configs["recommended-module"] = [
 	configs["package-json/recommended"],
 ];
 
-configs["recommended-commonjs"] = [
+configs["recommended-module"] = nodeRecommendedModule;
+configs["node-recommended-module"] = nodeRecommendedModule;
+
+const nodeRecommendedCommonJS = [
 	globalIgnores(ignorePaths),
 	configs["node/mixed-commonjs-and-module"],
 	javascriptConfig,
@@ -329,7 +337,10 @@ configs["recommended-commonjs"] = [
 	configs["package-json/recommended"],
 ];
 
-configs["recommended-dirty"] = [
+configs["recommended-commonjs"] = nodeRecommendedCommonJS;
+configs["node-recommended-commonjs"] = nodeRecommendedCommonJS;
+
+const nodeRecommendedDirty = [
 	globalIgnores(ignorePaths),
 	configs["node/mixed-dirty"],
 	javascriptConfig,
@@ -341,4 +352,57 @@ configs["recommended-dirty"] = [
 	configs["package-json/recommended"],
 ];
 
+configs["recommended-dirty"] = nodeRecommendedDirty;
+configs["node-recommended-dirty"] = nodeRecommendedDirty;
+
+const browserRecommended = [
+	globalIgnores(ignorePaths),
+	configs["browser/recommended"],
+	javascriptConfig,
+	typescriptJSDocConfig,
+	typescriptConfig,
+	jestConfig,
+	configs["markdown/recommended"],
+	configs["stylistic/recommended"],
+	configs["package-json/recommended"],
+];
+
+configs["browser-recommended"] = browserRecommended;
+
+const browserOutdatedRecommended = [
+	globalIgnores(ignorePaths),
+	configs["browser/recommended-outdated"],
+	{
+		...configs["javascript/es5"],
+		languageOptions: {
+			ecmaVersion: "latest",
+		},
+	},
+	typescriptJSDocConfig,
+	typescriptConfig,
+	jestConfig,
+	configs["markdown/recommended"],
+	configs["stylistic/recommended"],
+	configs["package-json/recommended"],
+];
+
+configs["browser-outdated-recommended"] = browserOutdatedRecommended;
+
+const universalRecommended = [
+	globalIgnores(ignorePaths),
+	configs["browser/recommended"],
+	isModule
+		? configs["node/mixed-module-and-commonjs"]
+		: configs["node/mixed-commonjs-and-module"],
+	javascriptConfig,
+	typescriptJSDocConfig,
+	typescriptConfig,
+	jestConfig,
+	configs["markdown/recommended"],
+	configs["stylistic/recommended"],
+	configs["package-json/recommended"],
+];
+
+configs["universal-recommended"] = universalRecommended;
+
 export { default } from "./configs/index.js";

configs/browser.js

@@ -2,6 +2,14 @@ import importPlugin from "eslint-plugin-import";
 import unicornPlugin from "eslint-plugin-unicorn";
 import globals from "globals";
 
+const recommendedBrowserOutdatedConfig = {
+	languageOptions: {
+		globals: {
+			...globals.browser,
+		},
+	},
+};
+
 const recommendedBrowserConfig = {
 	languageOptions: {
 		globals: {
@@ -27,10 +35,15 @@ const recommendedBrowserConfig = {
 
 		"unicorn/prefer-query-selector": "error",
 
-		"import/extensions": ["error", "always", { ignorePackages: true }],
+		"import/extensions": [
+			"error",
+			"always",
+			{ ignorePackages: true, checkTypeImports: true },
+		],
 	},
 };
 
 export default {
 	"browser/recommended": recommendedBrowserConfig,
+	"browser/recommended-outdated": recommendedBrowserOutdatedConfig,
 };

configs/javascript.js

@@ -1214,6 +1214,7 @@ function getConfig(esVersion) {
 	};
 
 	if (esVersion === 5) {
+		config.rules["arrow-body-style"] = "off";
 		config.rules["object-shorthand"] = "off";
 		config.rules["no-var"] = "off";
 		config.rules["prefer-arrow-callback"] = "off";
@@ -1226,6 +1227,8 @@ function getConfig(esVersion) {
 		config.rules["prefer-template"] = "off";
 		config.rules["no-template-curly-in-string"] = "off";
 		config.rules["unicorn/prefer-spread"] = "off";
+		config.rules["unicorn/prefer-includes"] = "off";
+		config.rules["unicorn/no-array-for-each"] = "off";
 	}
 
 	if (esVersion < 2018) {

eslint.config.js

@@ -8,6 +8,9 @@ export default defineConfig([
 			"./validation/commonjs-package/**/*",
 			"./validation/module-package/**/*",
 			"./validation/dirty-package/**/*",
+			"./validation/browser/**/*",
+			"./validation/browser-outdated/**/*",
+			"./validation/universal/**/*",
 		],
 		extends: [config],
 	},
@@ -33,6 +36,21 @@ export default defineConfig([
 			"n/no-unpublished-require": "off",
 		},
 	},
+	{
+		files: ["./validation/browser/**/*"],
+		extends: [configs["browser-recommended"]],
+	},
+	{
+		files: ["./validation/browser-outdated/**/*"],
+		extends: [configs["browser-outdated-recommended"]],
+	},
+	{
+		files: ["./validation/universal/**/*"],
+		extends: [configs["universal-recommended"]],
+		rules: {
+			"n/no-unsupported-features/node-builtins": "off",
+		},
+	},
 	{
 		files: ["./validation/hashbang.js"],
 		rules: {

validation/browser-outdated/code.js

@@ -0,0 +1,13 @@
+import sum from "./module.js";
+
+const heading = document.querySelector("h1");
+
+// Change the text content
+heading.textContent = "New Heading Text";
+
+// Add a new element
+const newParagraph = document.createElement("p");
+
+newParagraph.textContent = `Sum (1 + 2) = ${sum(1, 2)}`;
+
+heading.appendChild(newParagraph);

validation/browser-outdated/module.js

@@ -0,0 +1,8 @@
+/**
+ * @param {number} a number
+ * @param {number} b number
+ * @returns {number} sum
+ */
+export default function sum(a, b) {
+	return a + b;
+}

validation/browser/code.js

@@ -0,0 +1,13 @@
+import sum from "./module.js";
+
+const heading = document.querySelector("h1");
+
+// Change the text content
+heading.textContent = "New Heading Text";
+
+// Add a new element
+const newParagraph = document.createElement("p");
+
+newParagraph.textContent = `Sum (1 + 2) = ${sum(1, 2)}`;
+
+heading.append(newParagraph);

validation/browser/module.js

@@ -0,0 +1,8 @@
+/**
+ * @param {number} a number
+ * @param {number} b number
+ * @returns {number} sum
+ */
+export default function sum(a, b) {
+	return a + b;
+}

validation/universal/code.js

@@ -0,0 +1,70 @@
+/**
+ * @param {URL} url url
+ * @returns {Promise<Response>} result
+ */
+async function readFile(url) {
+	if (globalThis === globalThis.global) {
+		const fs = (await import("node:fs")).default;
+
+		return fs.promises.readFile(url, "utf8");
+	}
+
+	const response = await fetch(url);
+
+	return response.text();
+}
+
+/**
+ * @returns {Promise<[number, number, number]>} random numbers
+ */
+async function getRandomNumbers() {
+	const crypto =
+		globalThis === globalThis.global
+			? (await import("node:crypto")).webcrypto
+			: globalThis.crypto;
+
+	const array = new Uint8Array(3);
+	const randomNumbers = crypto.getRandomValues(array);
+
+	return [randomNumbers[0], randomNumbers[1], randomNumbers[2]];
+}
+
+let content;
+
+try {
+	content = await readFile(new URL("file.txt", import.meta.url));
+} catch (err) {
+	throw new Error("Error fetching data", { cause: err });
+}
+
+/**
+ * @returns {Promise<number>} number
+ */
+async function loadModule() {
+	if (globalThis === globalThis.global) {
+		const { createRequire } = await import("node:module");
+		const require = createRequire(import.meta.url);
+
+		return require("./module.cjs");
+	}
+
+	const module = (await import("./module.mjs")).default;
+
+	return module;
+}
+
+/**
+ * @returns {string} title
+ */
+function getTitle() {
+	return (globalThis.process && process.title) || document.title;
+}
+
+// eslint-disable-next-line
+console.log(content);
+// eslint-disable-next-line
+console.log(await getRandomNumbers());
+// eslint-disable-next-line
+console.log(await loadModule());
+// eslint-disable-next-line
+console.log(getTitle());

validation/universal/file.txt

@@ -0,0 +1 @@
+Text