refactor: migrate to ES module syntax (#5665)

* refactor: migrate to ES module syntax

* refactor: migrate ports-map.js to ES module syntax

* refactor: migrate helper files to ES module syntax

* refactor: migrate fixtures configs to ES module syntax

* refactor: migrate test files to ES module syntax

* refactor: migrate test files to ES module syntax

* refactor: migrate test files to use fileURLToPath for __dirname

* refactor: remove duplicate import of http in cross-origin request tests

* refactor: update library type to module and enable outputModule experiment in webpack config

* refactor: update client transport implementation checks and adjust module federation test assertions

* refactor: enhance client transport handling with pathToFileURL for absolute paths

* fixup!

* fixup!

* refactor: improve lazy loading of webpack peer dependency and update addAdditionalEntries to async

* fixup!

* refactor: update lazy initialization of webpack dev middleware to async

* refactor: update TypeScript configuration to target ES2024 and improve type definitions

* fixup!

* refactor: simplify package installation check using require.resolve

* fix: update Node.js target version in Babel configuration to 22.15.0

* fixup!

* fixup!

* refactor: dynamically import 'node:net' in Server class for improved module loading

* refactor: update type definition for onLoadQueue to ensure correct function signature

* fixup!

* refactor: migrate examples to ES module syntax and remove "use strict" directives

- Updated all example files to use ES module imports instead of CommonJS require.
- Removed unnecessary "use strict" directives from JavaScript files.
- Adjusted webpack configuration files to utilize import.meta for context and URL handling.
- Ensured consistent use of import statements across all examples.

* refactor: update webpack configuration and asset handling for improved module support

* refactor: update webSocketServer configuration to use object syntax for improved clarity

* refactor: update test coverage script to include additional directories for improved coverage reporting

Author: bjohansebas

.gitignore

@@ -7,6 +7,9 @@ npm-debug.log
 client
 !/examples/client
 !/test/client
+
+examples/**/dist
+
 coverage
 node_modules
 .vscode

babel.config.js

@@ -1,6 +1,4 @@
-"use strict";
-
-module.exports = (api) => {
+export default (api) => {
   api.cache(true);
 
   return {
@@ -24,7 +22,7 @@ module.exports = (api) => {
             "@babel/preset-env",
             {
               targets: {
-                node: "20.9.0",
+                node: "22.15.0",
               },
             },
           ],

bin/webpack-dev-server.js

@@ -2,17 +2,22 @@
 /* Based on webpack/bin/webpack.js */
 /* eslint-disable no-console */
 
-"use strict";
+import cp from "node:child_process";
+import { createRequire } from "node:module";
+import path from "node:path";
+import readLine from "node:readline";
+import { fileURLToPath, pathToFileURL } from "node:url";
+import fs from "graceful-fs";
+
+const require = createRequire(import.meta.url);
 
 /**
  * @param {string} command process to run
  * @param {string[]} args command line arguments
  * @returns {Promise<void>} promise
  */
-const runCommand = (command, args) => {
-  const cp = require("node:child_process");
-
-  return new Promise((resolve, reject) => {
+const runCommand = (command, args) =>
+  new Promise((resolve, reject) => {
     const executedCommand = cp.spawn(command, args, {
       stdio: "inherit",
       shell: true,
@@ -30,7 +35,6 @@ const runCommand = (command, args) => {
       }
     });
   });
-};
 
 /**
  * @param {string} packageName name of the package
@@ -41,63 +45,30 @@ const isInstalled = (packageName) => {
     return true;
   }
 
-  const path = require("node:path");
-  const fs = require("graceful-fs");
-
-  let dir = __dirname;
-
-  do {
-    try {
-      if (
-        fs.statSync(path.join(dir, "node_modules", packageName)).isDirectory()
-      ) {
-        return true;
-      }
-    } catch {
-      // Nothing
-    }
-  } while (dir !== (dir = path.dirname(dir)));
-
-  // https://github.com/nodejs/node/blob/v18.9.1/lib/internal/modules/cjs/loader.js#L1274
-  // @ts-expect-error
-  for (const internalPath of require("node:module").globalPaths) {
-    try {
-      if (fs.statSync(path.join(internalPath, packageName)).isDirectory()) {
-        return true;
-      }
-    } catch {
-      // Nothing
-    }
+  try {
+    require.resolve(packageName);
+    return true;
+  } catch {
+    return false;
   }
-
-  return false;
 };
 
 /**
  * @param {CliOption} cli options
- * @returns {void}
+ * @returns {Promise<void>}
  */
-const runCli = (cli) => {
+const runCli = async (cli) => {
   if (cli.preprocess) {
     cli.preprocess();
   }
 
-  const path = require("node:path");
-
-  const pkgPath = require.resolve(`${cli.package}/package.json`);
+  const pkgUrl = import.meta.resolve(`${cli.package}/package.json`);
+  const pkgPath = fileURLToPath(pkgUrl);
+  const pkg = (await import(pkgUrl, { with: { type: "json" } })).default;
 
-  const pkg = require(pkgPath);
+  const binPath = path.resolve(path.dirname(pkgPath), pkg.bin[cli.binName]);
 
-  if (pkg.type === "module" || /\.mjs/i.test(pkg.bin[cli.binName])) {
-    import(path.resolve(path.dirname(pkgPath), pkg.bin[cli.binName])).catch(
-      (error) => {
-        console.error(error);
-        process.exitCode = 1;
-      },
-    );
-  } else {
-    require(path.resolve(path.dirname(pkgPath), pkg.bin[cli.binName]));
-  }
+  await import(pathToFileURL(binPath).href);
 };
 
 /**
@@ -123,10 +94,6 @@ const cli = {
 };
 
 if (!cli.installed) {
-  const path = require("node:path");
-  const fs = require("graceful-fs");
-  const readLine = require("node:readline");
-
   const notify = `CLI for webpack must be installed.\n  ${cli.name} (${cli.url})\n`;
 
   console.error(notify);
@@ -187,14 +154,17 @@ if (!cli.installed) {
     );
 
     runCommand(packageManager, [...installOptions, cli.package])
-      .then(() => {
-        runCli(cli);
-      })
+      .then(() => runCli(cli))
       .catch((error) => {
         console.error(error);
         process.exitCode = 1;
       });
   });
 } else {
-  runCli(cli);
+  try {
+    await runCli(cli);
+  } catch (error) {
+    console.error(error);
+    process.exitCode = 1;
+  }
 }

client-src/clients/WebSocketClient.js

@@ -1,6 +1,6 @@
 import { log } from "../utils/log.js";
 
-/** @typedef {import("../index").EXPECTED_ANY} EXPECTED_ANY */
+/** @typedef {import("../index.js").EXPECTED_ANY} EXPECTED_ANY */
 
 /**
  * @implements {CommunicationClient}

client-src/globals.d.ts

@@ -20,5 +20,5 @@ declare module "ansi-html-community" {
     function setColors(colors: Record<string, string | string[]>): void;
   }
 
-  export = ansiHtmlCommunity;
+  export default ansiHtmlCommunity;
 }

client-src/index.js

@@ -9,7 +9,7 @@ import socket from "./socket.js";
 import { log, setLogLevel } from "./utils/log.js";
 import sendMessage from "./utils/sendMessage.js";
 
-// eslint-disable-next-line jsdoc/no-restricted-syntax
+// eslint-disable-next-line jsdoc/reject-any-type
 /** @typedef {any} EXPECTED_ANY */
 
 /**

client-src/overlay.js

@@ -3,7 +3,7 @@
 
 import ansiHTML from "ansi-html-community";
 
-/** @typedef {import("./index").EXPECTED_ANY} EXPECTED_ANY */
+/** @typedef {import("./index.js").EXPECTED_ANY} EXPECTED_ANY */
 
 /**
  * @type {(input: string, position: number) => number | undefined}
@@ -79,16 +79,16 @@ function encode(text) {
 
 /**
  * @typedef {object} Context
- * @property {'warning' | 'error'} level level
- * @property {(string  | Message)[]} messages messages
- * @property {'build' | 'runtime'} messageSource message source
+ * @property {"warning" | "error"} level level
+ * @property {(string | Message)[]} messages messages
+ * @property {"build" | "runtime"} messageSource message source
  */
 
 /** @typedef {{ type: string } & Record<string, EXPECTED_ANY>} Event */
 
 /**
  * @typedef {object} Options
- * @property {{ [state: string]: { on: Record<string, { target: string; actions?: Array<string> }> } }} states states
+ * @property {{ [state: string]: { on: Record<string, { target: string, actions?: string[] }> } }} states states
  * @property {Context} context context
  * @property {string} initial initial
  */
@@ -149,9 +149,9 @@ function createMachine({ states, context, initial }, { actions }) {
 
 /**
  * @typedef {object} ShowOverlayData
- * @property {'warning' | 'error'} level level
- * @property {(string  | Message)[]} messages messages
- * @property {'build' | 'runtime'} messageSource message source
+ * @property {"warning" | "error"} level level
+ * @property {(string | Message)[]} messages messages
+ * @property {"build" | "runtime"} messageSource message source
  */
 
 /**
@@ -390,7 +390,7 @@ const colors = {
 
 ansiHTML.setColors(colors);
 
-/** @typedef {Error & { file?: string, moduleName?: string, moduleIdentifier?: string, loc?: string, message?: string; stack?: string | string[] }} Message */
+/** @typedef {Error & { file?: string, moduleName?: string, moduleIdentifier?: string, loc?: string, message?: string, stack?: string | string[] }} Message */
 
 /**
  * @param {string} type type
@@ -450,7 +450,7 @@ const createOverlay = (options) => {
   let containerElement;
   /** @type {HTMLDivElement | null | undefined} */
   let headerElement;
-  /** @type {Array<(element: HTMLDivElement) => void>} */
+  /** @type {((element: HTMLDivElement) => void)[]} */
   let onLoadQueue = [];
   /** @type {Omit<TrustedTypePolicy, "createScript" | "createScriptURL"> | undefined} */
   let overlayTrustedTypesPolicy;
@@ -589,7 +589,7 @@ const createOverlay = (options) => {
    * @param {string} type type
    * @param {(string | Message)[]} messages messages
    * @param {undefined | false | string} trustedTypesPolicyName trusted types policy name
-   * @param {'build' | 'runtime'} messageSource message source
+   * @param {"build" | "runtime"} messageSource message source
    */
   function show(type, messages, trustedTypesPolicyName, messageSource) {
     ensureOverlayExists(() => {

client-src/utils/sendMessage.js

@@ -1,6 +1,6 @@
 /* global WorkerGlobalScope */
 
-/** @typedef {import("../index").EXPECTED_ANY} EXPECTED_ANY */
+/** @typedef {import("../index.js").EXPECTED_ANY} EXPECTED_ANY */
 
 // Send messages to the outside, so plugins can consume it.
 /**

client-src/webpack.config.js

@@ -1,23 +1,22 @@
-"use strict";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import webpack from "webpack";
+import { merge } from "webpack-merge";
 
-const path = require("node:path");
-const webpack = require("webpack");
-const { merge } = require("webpack-merge");
+const __dirname = path.dirname(fileURLToPath(import.meta.url));
 
 const library = {
   library: {
-    // type: "module",
-    type: "commonjs",
+    type: "module",
   },
 };
 
 const baseForModules = {
   devtool: false,
   mode: "development",
-  // TODO enable this in future after fix bug with `eval` in webpack
-  // experiments: {
-  //   outputModule: true,
-  // },
+  experiments: {
+    outputModule: true,
+  },
   output: {
     path: path.resolve(__dirname, "../client/modules"),
     ...library,
@@ -37,7 +36,7 @@ const baseForModules = {
   },
 };
 
-module.exports = [
+export default [
   merge(baseForModules, {
     entry: path.join(__dirname, "modules/logger/index.js"),
     output: {

commitlint.config.js

@@ -1,6 +1,4 @@
-"use strict";
-
-module.exports = {
+export default {
   extends: ["@commitlint/config-conventional"],
   rules: {
     "header-max-length": [0],