Skip to content

Commit d872d8b

Browse files
committed
Remove chromedriver dependency
since this gets automagically installed by Selenium these days. Also remove chromedriver symlink from githubs worker image so that selenium downloads a matching version rather than relying on the preinstalled version which might not be compatible with the browser
1 parent 8d168c5 commit d872d8b

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

.github/workflows/interop-tests.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
on:
22
schedule:
33
- cron: "30 5 * * *"
4+
45
jobs:
56
interop:
67
runs-on: ubuntu-latest
@@ -17,5 +18,6 @@ jobs:
1718
- run: npm install
1819
- run: BROWSER=${{matrix.browserA}} BVER=${{matrix.bver}} ./node_modules/travis-multirunner/setup.sh
1920
- run: BROWSER=${{matrix.browserB}} BVER=${{matrix.bver}} ./node_modules/travis-multirunner/setup.sh
21+
- run: sudo rm /usr/bin/chromedriver # remove preinstalled github chromedriver from $PATH
2022
- run: Xvfb :99 &
2123
- run: BROWSER_A=${{matrix.browserA}} BROWSER_B=${{matrix.browserB}} BVER=${{matrix.bver}} DISPLAY=:99.0 node_modules/.bin/jest --retries=3 test/interop/

.github/workflows/test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,6 @@ jobs:
2424
- uses: actions/setup-node@v3
2525
- run: npm install
2626
- run: BROWSER=${{matrix.browser}} BVER=${{matrix.version}} ./node_modules/travis-multirunner/setup.sh
27+
- run: sudo rm /usr/bin/chromedriver # remove preinstalled github chromedriver from $PATH
2728
- run: Xvfb :99 &
2829
- run: BROWSER=${{matrix.browser}} BVER=${{matrix.version}} DISPLAY=:99.0 npm run jest -- --retries=3

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
"'**/third_party/*.js'"
3030
],
3131
"devDependencies": {
32-
"chromedriver": ">98.0.1",
3332
"eslint": "^8.9.0",
3433
"eslint-config-google": "^0.14.0",
3534
"eslint-plugin-jest": "^27.4.0",

0 commit comments

Comments
 (0)