Skip to content

Commit e04eb30

Browse files
Merge pull request #158 from wework/rq-expose-rollbar
Exposes rollbar for the node logger
2 parents 9e9b1eb + aea217c commit e04eb30

File tree

4 files changed

+13
-3
lines changed

4 files changed

+13
-3
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
"hide-secrets": "1.1.0",
7373
"le_js": "git://github.com/nason/le_js.git#7a75be7c1dd2438e3f1183a68bd2162b80bc94d8",
7474
"le_node": "^1.7.0",
75-
"lodash": "^4.17.4",
75+
"lodash": "^4.17.5",
7676
"rollbar": "^2.3.1",
7777
"uuid": "3.1.0"
7878
},

src/node.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ export default function NodeLogger(config = {}, logger) {
7575
// Server-specific extras
7676
this.requestLogger = createRequestLogger(this, serverConfig);
7777

78-
const rollbar = new Rollbar({
78+
this.rollbar = new Rollbar({
7979
accessToken: config.rollbarToken,
8080
});
81-
this.rollbarErrorMiddleware = rollbar.errorHandler();
81+
this.rollbarErrorMiddleware = this.rollbar.errorHandler();
8282
}
8383

8484
/* eslint-disable prefer-spread, prefer-rest-params */

test/specs/logger.spec.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,12 @@ describe('we-js-logger', () => {
1919
expect(Logger.bunyanStdSerializers).to.eql(stdSerializers);
2020
});
2121

22+
if (typeof document === 'undefined') {
23+
it('exposes the rollbar instance', () => {
24+
expect(new Logger()).to.have.property('rollbar');
25+
});
26+
}
27+
2228
describe('options', () => {
2329
it('accepts a name', () => {
2430
const name = 'WeTest!';

yarn.lock

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4438,6 +4438,10 @@ lodash@^4.0.1, lodash@^4.11.1, lodash@^4.14.0, lodash@^4.16.6, lodash@^4.17.4, l
44384438
version "4.17.4"
44394439
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.4.tgz#78203a4d1c328ae1d86dca6460e369b57f4055ae"
44404440

4441+
lodash@^4.17.5:
4442+
version "4.17.10"
4443+
resolved "https://registry.npmjs.org/lodash/-/lodash-4.17.10.tgz#1b7793cf7259ea38fb3661d4d38b3260af8ae4e7"
4444+
44414445
log-driver@^1.2.5:
44424446
version "1.2.5"
44434447
resolved "https://registry.yarnpkg.com/log-driver/-/log-driver-1.2.5.tgz#7ae4ec257302fd790d557cb10c97100d857b0056"

0 commit comments

Comments
 (0)