-
Notifications
You must be signed in to change notification settings - Fork 352
Open
Labels
Description
Feedback on #1647 to keep the overall PR in terms of comments and such somewhat smaller in size.
- Put the new method under the existing "Fetch method" heading, but rename it to "Fetch methods". "Fetch" in this heading is not a reference to
fetch()
, but to the fact that the method can fetch. So "FetchLater method" doesn't make a whole lot of sense in that light. -
FetchLaterResult
needs to be[Exposed]
. - User agent is without hyphen, see Infra.
- "Not allowed in this context" is woefully vague. Can we do better or even agree on a model here?
- If the exceptions are meant to be
DOMException
that should follow the style for them. - "This may throw an exception." we generally don't state this.
- "If request’s URL is not a potentially trustworthy url," This is a Mixed Content consideration and should be caught by the network layer, not the API.
- "exists then" missing comma.
- "DOMHighResTimeStamp then" missing comma.
- "0 then" missing comma.
- I would put an
<hr>
before the deferred fetch record definition. - Why are some request body checks made inside
fetchLater()
and some inside "request a deferred fetch"? - "The user agent may process deferred fetches at any given moment" This seems wrong? I suppose it's only when the browser expects that the fetch groups will die? (Unfortunately fetch groups are not well-defined...)
- "process deferred fetches for fetchGroup." needs uppercase P at the start.