fix(api-gateway-v2): remove duplicate cookies for function URLs #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function URLs get cookies twice, in headers and the `cookies` array, which was causing them to duplicate. Ref: awslabs/aws-lambda-rust-runtime#586
Today, out of the blue, function URLs started escaping the `rawQueryString`, which resulted in double escaping which breaks everything. The query string is available on `event.queryStringParameters`, though, and that "just works."
Author
|
Today function my remix app behind a function URL broke for me suddenly. It seems to me that AWS started escaping the I added another commit here just for visibility; I am not sure the cookie one is needed anymore (but doesn't hurt). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function URLs get cookies twice, in headers and the
cookiesarray, which was causing them to duplicate. This will overwrite rather than duplicate.Ref: awslabs/aws-lambda-rust-runtime#586
Function URLs use the same apigatewayv2 payload otherwise.