Skip to content

Fix for big photos from esp32 cam. Split the buffer into chunks 512b #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for big photos from esp32 cam. Split the buffer into chunks 512b #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions src/UniversalTelegramBot.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,11 +256,33 @@ String UniversalTelegramBot::sendMultipartFormDataToTelegram(

if (getNextByteCallback == nullptr) {
while (moreDataAvailableCallback()) {
client->write((const uint8_t *)getNextBufferCallback(), getNextBufferLenCallback());
#ifdef TELEGRAM_DEBUG
Serial.println(F("Sending photo from buffer"));
#endif
//split the buffer into chunks 512b for big buffers (example for framebuffer higher resolution photos (>320x240))
unsigned int fbSize = getNextBufferLenCallback() ;
uint8_t* fBuffer = getNextBufferCallback();

uint8_t buffer[512];
unsigned int count = 0;
unsigned int i = 0;
while (i <= fbSize) {
buffer[count] = fBuffer[i];
i++;
count++;
if (count == 512) {
#ifdef TELEGRAM_DEBUG
Serial.println(F("Sending photo from buffer - chunk"));
#endif
client->write((const uint8_t *)buffer, 512);
count = 0;
}
}
if (count > 0) {
#ifdef TELEGRAM_DEBUG
Serial.println(F("Sending photo from buffer - remaining chunk"));
Serial.println(count);
#endif
client->write((const uint8_t *)buffer, count);
}
}
} else {
#ifdef TELEGRAM_DEBUG
Serial.println(F("Sending photo by binary"));
Expand Down