Minor improvements to Burn, tests, and doc.

Author: barnson

src/burn/engine/core.cpp

@@ -383,7 +383,7 @@ extern "C" HRESULT CoreDetect(
             pEngineState->registration.fEligibleForCleanup = FALSE;
         }
 
-        LogId(REPORT_STANDARD, MSG_DETECTED_PACKAGE, pPackage->sczId, LoggingPackageStateToString(pPackage->currentState), LoggingBoolToString(pPackage->fCached), LoggingPackageRegistrationStateToString(pPackage->fCanAffectRegistration, pPackage->installRegistrationState), LoggingPackageRegistrationStateToString(pPackage->fCanAffectRegistration, pPackage->cacheRegistrationState), LoggingPackageScopeToString(pPackage->scope), LoggingInstallScopeToString(pPackage->fDetectedPerMachine));
+        LogId(REPORT_STANDARD, MSG_DETECTED_PACKAGE, pPackage->sczId, LoggingPackageStateToString(pPackage->currentState), BURN_PACKAGE_TYPE_MSI == pPackage->type ? LoggingBoolToString(pPackage->fCached) : "(not configurable scope)", LoggingPackageRegistrationStateToString(pPackage->fCanAffectRegistration, pPackage->installRegistrationState), LoggingPackageRegistrationStateToString(pPackage->fCanAffectRegistration, pPackage->cacheRegistrationState), LoggingPackageScopeToString(pPackage->scope), LoggingInstallScopeToString(pPackage->fDetectedPerMachine));
 
         if (BURN_PACKAGE_TYPE_MSI == pPackage->type)
         {

src/test/wix/WixE2E/WixE2EFixture.cs

@@ -136,35 +136,36 @@ public void CanIncrementalBuildPackageWithNativeWindowsAppWithEdits()
             Assert.AreNotEqual(firstHashes, secondHashes);
         }
 
-        //[TestMethod]
+        [Ignore]
+        [TestMethod]
         //[Fact(Skip = "Investigate if .NET Core WebApplications can be incrementally built")]
-        //public void CanIncrementalBuildPackageWithNetCoreWebAppWithoutEdits()
-        //{
-        //    var projectDirectory = TestData.Get("TestData", "WixprojPackageCsprojWebApplicationNetCore");
-        //    var projectPath = Path.Combine(projectDirectory, "WixprojPackageCsprojWebApplicationNetCore.wixproj");
-        //    var projectBinPath = Path.Combine(projectDirectory, "bin");
+        public void CanIncrementalBuildPackageWithNetCoreWebAppWithoutEdits()
+        {
+            var projectDirectory = TestData.Get("TestData", "WixprojPackageCsprojWebApplicationNetCore");
+            var projectPath = Path.Combine(projectDirectory, "WixprojPackageCsprojWebApplicationNetCore.wixproj");
+            var projectBinPath = Path.Combine(projectDirectory, "bin");
 
-        //    CleanEverything();
+            CleanEverything();
 
-        //    var result = RestoreAndBuild(projectPath);
-        //    result.AssertSuccess();
+            var result = RestoreAndBuild(projectPath);
+            result.AssertSuccess();
 
-        //    var firstBuiltFiles = Directory.GetFiles(projectBinPath, "*.*", SearchOption.AllDirectories).ToArray();
-        //    var firstHashes = firstBuiltFiles.Select(s => $"{s.Substring(projectBinPath.Length).TrimStart('\\')} with hash: {GetFileHash(s)}").ToArray();
+            var firstBuiltFiles = Directory.GetFiles(projectBinPath, "*.*", SearchOption.AllDirectories).ToArray();
+            var firstHashes = firstBuiltFiles.Select(s => $"{s.Substring(projectBinPath.Length).TrimStart('\\')} with hash: {GetFileHash(s)}").ToArray();
 
-        //    //var packageWxsPath = Path.Combine(projectDirectory, "Package.wxs");
-        //    //File.SetLastWriteTime(packageWxsPath, DateTime.Now);
+            //var packageWxsPath = Path.Combine(projectDirectory, "Package.wxs");
+            //File.SetLastWriteTime(packageWxsPath, DateTime.Now);
 
-        //    // This should be an incremental build that does work because a file was updated.
-        //    //
-        //    result = RestoreAndBuild(projectPath);
-        //    result.AssertSuccess();
+            // This should be an incremental build that does work because a file was updated.
+            //
+            result = RestoreAndBuild(projectPath);
+            result.AssertSuccess();
 
-        //    var secondBuiltFiles = Directory.GetFiles(projectBinPath, "*.*", SearchOption.AllDirectories).ToArray();
-        //    var secondHashes = secondBuiltFiles.Select(s => $"{s.Substring(projectBinPath.Length).TrimStart('\\')} with hash: {GetFileHash(s)}").ToArray();
+            var secondBuiltFiles = Directory.GetFiles(projectBinPath, "*.*", SearchOption.AllDirectories).ToArray();
+            var secondHashes = secondBuiltFiles.Select(s => $"{s.Substring(projectBinPath.Length).TrimStart('\\')} with hash: {GetFileHash(s)}").ToArray();
 
-        //    WixAssert.CompareLineByLine(firstHashes, secondHashes);
-        //}
+            WixAssert.CompareLineByLine(firstHashes, secondHashes);
+        }
 
         private static void CleanEverything()
         {

src/xsd/wix/Upgrade.xsd

@@ -14,7 +14,7 @@
           <annotation>
             <documentation>
               Nesting a Property element under an Upgrade element has been deprecated.
-              Please nest Property elements in any of the other supported locations.
+              Use ProductSearch instead.
             </documentation>
           </annotation>
         </element>
@@ -25,4 +25,4 @@
         </annotation>
       </attribute>
     </complexType>
-  </element>
+  </element>