Skip to content

Fixes for crypto callback only (no filesystem and keygen) #9194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

Fixes for crypto callback only (no filesystem and keygen) #9194

merged 1 commit into from
Oct 2, 2025

Conversation

@dgarske
Copy link
Contributor

@dgarske dgarske commented Sep 12, 2025

Description

Fixes for crypto callback only

Testing

./configure --enable-cryptocb CFLAGS="-DWOLF_CRYPTO_CB_ONLY_RSA -DWOLF_CRYPTO_CB_ONLY_ECC" --disable-filesystem --enable-keygen && make check

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@dgarske dgarske self-assigned this Sep 12, 2025
@dgarske
Copy link
Contributor Author

dgarske commented Sep 26, 2025

Jenkins retest this please

@dgarske
Copy link
Contributor Author

dgarske commented Sep 30, 2025

Jenkins retest this please

@dgarske dgarske assigned wolfSSL-Bot and unassigned dgarske Oct 1, 2025
@dgarske dgarske requested a review from douzzer October 1, 2025 01:43
douzzer
douzzer approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

note we should eventually circle back to get a deeper understanding of why NO_WRITE_TEMP_FILES is needed for WOLF_CRYPTO_CB_ONLY_ECC WOLF_CRYPTO_CB_ONLY_RSA.

@douzzer douzzer merged commit 5804ba7 into wolfSSL:master Oct 2, 2025
253 checks passed
dgarske added a commit to dgarske/wolfssl that referenced this pull request Oct 3, 2025
@dgarske
Remove the NO_WRITE_TEMP_FILES test.c logic added in wolfSSL#9194
d2be867
@dgarske dgarske mentioned this pull request Oct 3, 2025
Merged
4 tasks
@dgarske
Copy link
Contributor Author

dgarske commented Oct 3, 2025

LGTM

note we should eventually circle back to get a deeper understanding of why NO_WRITE_TEMP_FILES is needed for WOLF_CRYPTO_CB_ONLY_ECC WOLF_CRYPTO_CB_ONLY_RSA.

Reverted that section of code: see #9268

douzzer added a commit that referenced this pull request Oct 3, 2025
@douzzer
Merge pull request #9268 from dgarske/cryptocb_only
781c9bb 
Remove the `NO_WRITE_TEMP_FILES` test.c logic added in #9194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@douzzer douzzer douzzer approved these changes

Assignees

@wolfSSL-Bot wolfSSL-Bot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dgarske @douzzer @wolfSSL-Bot