Update AttendanceStatus and bookings fields without fetching an order

Author: AdamGrzybkowski

libs/fluxc-plugin/src/main/kotlin/org/wordpress/android/fluxc/network/rest/wpcom/wc/bookings/BookingsStore.kt

@@ -155,20 +155,26 @@ class BookingsStore @Inject internal constructor(
                 response.isError -> WooResult(response.error)
                 response.result != null -> {
                     val bookingDto = response.result
-                    val orderResult = bookingDto.orderId.takeIf { it != 0L }?.let {
-                        orderStore.fetchSingleOrderSync(site, bookingDto.orderId)
-                    }
-                    if (orderResult?.isError == true) {
-                        return@withDefaultContext WooResult(orderResult.error)
+
+                    val storedBooking = bookingsDao.getBooking(
+                        localSiteId = site.localId(),
+                        bookingId = bookingId
+                    )
+                    if (storedBooking == null) {
+                        return@withDefaultContext WooResult(WooError(GENERIC_ERROR, UNKNOWN))
                     }
-                    val entity = with(bookingDtoMapper) {
-                        bookingDto.toEntity(
+
+                    with(bookingDtoMapper) {
+                        val updatedBooking = bookingDto.toEntity(
                             localSiteId = site.localId(),
-                            orderEntity = orderResult?.model,
+                            orderEntity = null,
+                        ).copy(
+                            // Preserve fields not returned by the API
+                            order = storedBooking.order,
                         )
+                        bookingsDao.insertOrReplace(updatedBooking)
+                        return@withDefaultContext WooResult(updatedBooking)
                     }
-                    bookingsDao.insertOrReplace(listOf(entity))
-                    WooResult(entity)
                 }
 
                 else -> WooResult(WooError(GENERIC_ERROR, UNKNOWN))

libs/fluxc-plugin/src/main/kotlin/org/wordpress/android/fluxc/persistence/dao/BookingsDao.kt

@@ -99,6 +99,9 @@ interface BookingsDao {
         )
     }
 
+    @Query("SELECT * FROM Bookings WHERE localSiteId = :localSiteId AND id = :bookingId LIMIT 1")
+    suspend fun getBooking(localSiteId: LocalId, bookingId: Long): BookingEntity?
+
     @Query("SELECT * FROM BookingResources WHERE localSiteId = :localSiteId AND id = :resourceId")
     fun observeResource(localSiteId: LocalId, resourceId: Long): Flow<BookingResourceEntity?>