Improve naming of state class and vals

Author: samiuelson

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosCatalogSyncOverdueBanner.kt

@@ -35,12 +35,12 @@ import com.woocommerce.android.ui.woopos.common.composeui.designsystem.WooPosTyp
 
 @Composable
 fun WooPosCatalogSyncOverdueBanner(
-    bannerState: WooPosItemsViewModel.CatalogSyncBannerState,
+    state: WooPosItemsViewModel.CatalogSyncOverdueBannerState,
     modifier: Modifier = Modifier,
     onDismiss: () -> Unit
 ) {
     AnimatedVisibility(
-        visible = bannerState is WooPosItemsViewModel.CatalogSyncBannerState.OverdueSyncWarning,
+        visible = state is WooPosItemsViewModel.CatalogSyncOverdueBannerState.Visible,
         enter = fadeIn(
             animationSpec = tween(durationMillis = 180)
         ) + scaleIn(
@@ -106,7 +106,7 @@ fun WooPosCatalogSyncOverdueBanner(
 fun WooPosRefreshCatalogBannerPreview() {
     WooPosTheme {
         WooPosCatalogSyncOverdueBanner(
-            bannerState = WooPosItemsViewModel.CatalogSyncBannerState.OverdueSyncWarning,
+            state = WooPosItemsViewModel.CatalogSyncOverdueBannerState.Visible,
             onDismiss = {}
         )
     }

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsScreen.kt

@@ -65,7 +65,7 @@ fun WooPosItemsScreen(
     WooPosItemsScreen(
         modifier = modifier,
         itemsStateFlow = productsViewModel.viewState,
-        catalogSyncBannerStateFlow = productsViewModel.catalogSyncBannerState,
+        catalogSyncOverdueBannerStateFlow = productsViewModel.catalogSyncOverdueBannerState,
         productsViewState = productsViewState,
         couponsListState = couponsListState,
         catalogSyncState = catalogSyncState,
@@ -79,15 +79,15 @@ fun WooPosItemsScreen(
 private fun WooPosItemsScreen(
     modifier: Modifier = Modifier,
     itemsStateFlow: StateFlow<WooPosItemsToolbarViewState>,
-    catalogSyncBannerStateFlow: StateFlow<WooPosItemsViewModel.CatalogSyncBannerState>,
+    catalogSyncOverdueBannerStateFlow: StateFlow<WooPosItemsViewModel.CatalogSyncOverdueBannerState>,
     productsViewState: LazyListState,
     couponsListState: LazyListState,
     catalogSyncState: CatalogSyncState,
     onRetryCatalogSync: () -> Unit,
     onUIEvent: (WooPosItemsUIEvent) -> Unit,
 ) {
     val state = itemsStateFlow.collectAsState()
-    val catalogSyncOverdueBannerState = catalogSyncBannerStateFlow.collectAsState()
+    val catalogSyncOverdueBannerState = catalogSyncOverdueBannerStateFlow.collectAsState()
 
     MainItemsList(
         modifier = modifier,
@@ -125,7 +125,7 @@ private fun WooPosItemsScreen(
 private fun MainItemsList(
     modifier: Modifier,
     state: State<WooPosItemsToolbarViewState>,
-    bannerState: State<WooPosItemsViewModel.CatalogSyncBannerState>,
+    bannerState: State<WooPosItemsViewModel.CatalogSyncOverdueBannerState>,
     productsViewState: LazyListState,
     couponsListState: LazyListState,
     catalogSyncState: CatalogSyncState,
@@ -159,7 +159,7 @@ private fun MainItemsList(
             )
 
             WooPosCatalogSyncOverdueBanner(
-                bannerState = bannerState.value,
+                state = bannerState.value,
                 onDismiss = onSyncWarningBannerDismissed
             )
 
@@ -324,12 +324,12 @@ fun WooPosItemsScreenSearchVisiblePreview(modifier: Modifier = Modifier) {
             tabs = tabs()
         )
     )
-    val bannerState = MutableStateFlow(WooPosItemsViewModel.CatalogSyncBannerState.OverdueSyncWarning)
+    val bannerState = MutableStateFlow(WooPosItemsViewModel.CatalogSyncOverdueBannerState.Visible)
     WooPosTheme {
         WooPosItemsScreen(
             modifier = modifier,
             itemsStateFlow = productState,
-            catalogSyncBannerStateFlow = bannerState,
+            catalogSyncOverdueBannerStateFlow = bannerState,
             productsViewState = rememberLazyListState(),
             couponsListState = rememberLazyListState(),
             catalogSyncState = CatalogSyncState.Idle,
@@ -354,12 +354,12 @@ fun WooPosItemsScreenSearchHiddenPreview(modifier: Modifier = Modifier) {
             tabs = tabs()
         )
     )
-    val bannerState = MutableStateFlow(WooPosItemsViewModel.CatalogSyncBannerState.OverdueSyncWarning)
+    val bannerState = MutableStateFlow(WooPosItemsViewModel.CatalogSyncOverdueBannerState.Visible)
     WooPosTheme {
         WooPosItemsScreen(
             modifier = modifier,
             itemsStateFlow = productState,
-            catalogSyncBannerStateFlow = bannerState,
+            catalogSyncOverdueBannerStateFlow = bannerState,
             productsViewState = rememberLazyListState(),
             couponsListState = rememberLazyListState(),
             catalogSyncState = CatalogSyncState.Idle,

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsViewModel.kt

@@ -48,8 +48,8 @@ class WooPosItemsViewModel @Inject constructor(
             initialValue = _viewState.value,
         )
 
-    private val _catalogSyncBannerState = MutableStateFlow<CatalogSyncBannerState>(CatalogSyncBannerState.Hidden)
-    val catalogSyncBannerState: StateFlow<CatalogSyncBannerState> = _catalogSyncBannerState
+    private val _catalogSyncOverdueBannerState = MutableStateFlow<CatalogSyncOverdueBannerState>(CatalogSyncOverdueBannerState.Hidden)
+    val catalogSyncOverdueBannerState: StateFlow<CatalogSyncOverdueBannerState> = _catalogSyncOverdueBannerState
 
     init {
         listenUpEvents()
@@ -68,9 +68,9 @@ class WooPosItemsViewModel @Inject constructor(
     private fun checkSyncStatusAndUpdateBanner() {
         viewModelScope.launch {
             val requirement = syncStatusChecker.checkSyncRequirement()
-            _catalogSyncBannerState.value = when (requirement) {
-                is WooPosFullSyncRequirement.Overdue -> CatalogSyncBannerState.OverdueSyncWarning
-                else -> CatalogSyncBannerState.Hidden
+            _catalogSyncOverdueBannerState.value = when (requirement) {
+                is WooPosFullSyncRequirement.Overdue -> CatalogSyncOverdueBannerState.Visible
+                else -> CatalogSyncOverdueBannerState.Hidden
             }
         }
     }
@@ -96,7 +96,7 @@ class WooPosItemsViewModel @Inject constructor(
 
             is WooPosItemsUIEvent.AddCouponIconClicked -> createAndAddCoupon()
             WooPosItemsUIEvent.SyncOverdueBannerDismissed -> {
-                _catalogSyncBannerState.value = CatalogSyncBannerState.Hidden
+                _catalogSyncOverdueBannerState.value = CatalogSyncOverdueBannerState.Hidden
             }
         }
     }
@@ -263,8 +263,8 @@ class WooPosItemsViewModel @Inject constructor(
         data class Coupon(override val id: Long, val couponCode: String) : ItemClickedData(id), Parcelable
     }
 
-    sealed class CatalogSyncBannerState {
-        data object Hidden : CatalogSyncBannerState()
-        data object OverdueSyncWarning : CatalogSyncBannerState()
+    sealed class CatalogSyncOverdueBannerState {
+        data object Hidden : CatalogSyncOverdueBannerState()
+        data object Visible : CatalogSyncOverdueBannerState()
     }
 }