Skip to content

Commit f545b16

Browse files
ParaskP7ParaskP7
committed
Merge branch 'trunk' of github.com:woocommerce/woocommerce-android into tooling/integrate-automattic-enryptedlogging-1.0.0
2 parents 2b8d77c + 5ccecb6 commit f545b16

File tree

26 files changed

+6309
-243
lines changed

26 files changed

+6309
-243
lines changed

‎.buildkite/commands/lint.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,6 @@ if [ $app_lint_exit_code -ne 0 ] || [ $wear_lint_exit_code -ne 0 ]; then
2020
fi
2121

2222
upload_sarif_to_github 'WooCommerce/build/reports/lint-results-jalapenoDebug.sarif'
23+
upload_sarif_to_github 'WooCommerce-Wear/build/reports/lint-results-jalapenoDebug.sarif'
2324

2425
exit $lint_exit_code

‎WooCommerce-Wear/build.gradle

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,10 @@ android {
120120
}
121121
}
122122
}
123+
124+
lintOptions {
125+
checkDependencies = false
126+
}
123127
}
124128

125129
dependencies {
@@ -206,7 +210,6 @@ dependencies {
206210
// See https://github.com/wordpress-mobile/WordPress-FluxC-Android/issues/919
207211
exclude group: 'com.squareup.okhttp3'
208212
}
209-
lintChecks(libs.android.security.lint)
210213
}
211214

212215
android.buildTypes.all { buildType ->

‎WooCommerce-Wear/lint-baseline.xml

Lines changed: 114 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,114 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<issues format="6" by="lint 8.8.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.8.0)" variant="all" version="8.8.0">
3+
4+
<issue
5+
id="DoNotMockDataClass"
6+
message="&apos;com.woocommerce.commons.WearOrderedProduct&apos; is a data class, so mocking it should not be necessary"
7+
errorLine1=" val expectedProducts = listOf&lt;WearOrderedProduct>(mock())"
8+
errorLine2=" ~~~~~~">
9+
<location
10+
file="src/test/java/com/woocommerce/android/wear/ui/orders/details/FetchOrderProductsTest.kt"
11+
line="56"
12+
column="59"/>
13+
</issue>
14+
15+
<issue
16+
id="DoNotMockDataClass"
17+
message="&apos;com.woocommerce.commons.WearOrder&apos; is a data class, so mocking it should not be necessary"
18+
errorLine1=" val expectedOrders = listOf&lt;WearOrder>(mock())"
19+
errorLine2=" ~~~~~~">
20+
<location
21+
file="src/test/java/com/woocommerce/android/wear/ui/orders/list/FetchOrdersTest.kt"
22+
line="87"
23+
column="48"/>
24+
</issue>
25+
26+
<issue
27+
id="DoNotMockDataClass"
28+
message="&apos;org.wordpress.android.fluxc.model.WCRevenueStatsModel&apos; is a data class, so mocking it should not be necessary"
29+
errorLine1=" val revenueStats = mock&lt;WCRevenueStatsModel> {"
30+
errorLine2=" ^">
31+
<location
32+
file="src/test/java/com/woocommerce/android/wear/complications/FetchStatsForComplicationsTest.kt"
33+
line="39"
34+
column="28"/>
35+
</issue>
36+
37+
<issue
38+
id="DoNotMockDataClass"
39+
message="&apos;org.wordpress.android.fluxc.model.WCRevenueStatsModel&apos; is a data class, so mocking it should not be necessary"
40+
errorLine1=" val revenueStats = mock&lt;WCRevenueStatsModel> {"
41+
errorLine2=" ^">
42+
<location
43+
file="src/test/java/com/woocommerce/android/wear/complications/FetchStatsForComplicationsTest.kt"
44+
line="68"
45+
column="28"/>
46+
</issue>
47+
48+
<issue
49+
id="DoNotMockDataClass"
50+
message="&apos;org.wordpress.android.fluxc.model.WCRevenueStatsModel&apos; is a data class, so mocking it should not be necessary"
51+
errorLine1=" val revenueResponse = mock&lt;WCRevenueStatsModel> {"
52+
errorLine2=" ^">
53+
<location
54+
file="src/test/java/com/woocommerce/android/wear/ui/stats/datasource/FetchStatsTest.kt"
55+
line="110"
56+
column="31"/>
57+
</issue>
58+
59+
<issue
60+
id="DoNotMockDataClass"
61+
message="&apos;org.wordpress.android.fluxc.persistence.entity.OrderEntity&apos; is a data class, so mocking it should not be necessary"
62+
errorLine1=" val order1 = mock&lt;OrderEntity> { on { dateCreated } doReturn &quot;1000&quot; }"
63+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
64+
<location
65+
file="src/test/java/com/woocommerce/android/wear/ui/orders/OrdersRepositoryTest.kt"
66+
line="37"
67+
column="22"/>
68+
</issue>
69+
70+
<issue
71+
id="DoNotMockDataClass"
72+
message="&apos;org.wordpress.android.fluxc.persistence.entity.OrderEntity&apos; is a data class, so mocking it should not be necessary"
73+
errorLine1=" val order2 = mock&lt;OrderEntity> { on { dateCreated } doReturn &quot;2000&quot; }"
74+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
75+
<location
76+
file="src/test/java/com/woocommerce/android/wear/ui/orders/OrdersRepositoryTest.kt"
77+
line="38"
78+
column="22"/>
79+
</issue>
80+
81+
<issue
82+
id="DoNotMockDataClass"
83+
message="&apos;org.wordpress.android.fluxc.persistence.entity.OrderEntity&apos; is a data class, so mocking it should not be necessary"
84+
errorLine1=" val order3 = mock&lt;OrderEntity> { on { dateCreated } doReturn &quot;1500&quot; }"
85+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
86+
<location
87+
file="src/test/java/com/woocommerce/android/wear/ui/orders/OrdersRepositoryTest.kt"
88+
line="39"
89+
column="22"/>
90+
</issue>
91+
92+
<issue
93+
id="DoNotMockDataClass"
94+
message="&apos;com.woocommerce.android.wear.settings.AppSettings.CrashReportEnabledSettings&apos; is a data class, so mocking it should not be necessary"
95+
errorLine1=" val settingsMock = mock&lt;CrashReportEnabledSettings>()"
96+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
97+
<location
98+
file="src/test/java/com/woocommerce/android/wear/crashlogging/WCWearCrashLoggingDataProviderTest.kt"
99+
line="63"
100+
column="28"/>
101+
</issue>
102+
103+
<issue
104+
id="DoNotMockDataClass"
105+
message="&apos;com.woocommerce.android.wear.settings.AppSettings.CrashReportEnabledSettings&apos; is a data class, so mocking it should not be necessary"
106+
errorLine1=" val settingsMock = mock&lt;CrashReportEnabledSettings>()"
107+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
108+
<location
109+
file="src/test/java/com/woocommerce/android/wear/crashlogging/WCWearCrashLoggingDataProviderTest.kt"
110+
line="74"
111+
column="28"/>
112+
</issue>
113+
114+
</issues>

‎WooCommerce/build.gradle

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,9 +169,7 @@ android {
169169
}
170170

171171
lintOptions {
172-
sarifReport = gradle.ext.isCi
173172
checkDependencies = true
174-
disable 'InvalidPackage'
175173
}
176174

177175
testOptions {
@@ -433,8 +431,6 @@ dependencies {
433431

434432
implementation(libs.google.protobuf.javalite)
435433

436-
lintChecks(libs.android.security.lint)
437-
438434
testImplementation(testFixtures(project(":libs:fluxc-plugin")))
439435

440436
androidTestUtil libs.androidx.test.orchestrator

0 commit comments

Comments
 (0)