-
Notifications
You must be signed in to change notification settings - Fork 10
Labels
changelog: fixTook care of something that wasn't working.Took care of something that wasn't working.impact: highThis issue impacts a lot of users as reported by our Happiness Engineers.This issue impacts a lot of users as reported by our Happiness Engineers.status: blockedThe issue is blocked from progressing, waiting for another piece of work to be done.The issue is blocked from progressing, waiting for another piece of work to be done.type: enhancementThe issue is a request for an enhancement.The issue is a request for an enhancement.
Description
Currently, two preview images of both the Apple Pay and Google Pay buttons are being rendered in the editor. The first issue here is that only one of these should be rendered per slot, otherwise it breaks the grid layout (see screenshot)
The first 2 images of Apple Pay and Google Pay in the top left come from the Square extension.
With new changes about to be introduced in Core in woocommerce/woocommerce#50791, we are asking payment extensions to render the actual buttons in the editor instead of a preview. This has several benefits:
- It gives the merchant a more accurate representation of what the shopper would see on the front end of a store
- It provides feedback to the merchant as to which express payment buttons support the new height and border radius controls
This will involve:
- loading the SDK or client side scripts which load the button in the editor
- When calling
registerExpressPaymentMethod
, passing the same component to theedit
property as thecontent
property.
Please reach out if you need any help
Metadata
Metadata
Assignees
Labels
changelog: fixTook care of something that wasn't working.Took care of something that wasn't working.impact: highThis issue impacts a lot of users as reported by our Happiness Engineers.This issue impacts a lot of users as reported by our Happiness Engineers.status: blockedThe issue is blocked from progressing, waiting for another piece of work to be done.The issue is blocked from progressing, waiting for another piece of work to be done.type: enhancementThe issue is a request for an enhancement.The issue is a request for an enhancement.