Skip to content

Fix intersections with primitives to add support for nominal types #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix intersections with primitives to add support for nominal types #120

wants to merge 2 commits into from

Conversation

@MurhafElmasri
Copy link

@MurhafElmasri MurhafElmasri commented Dec 21, 2021 •
edited
Loading

as issue #110 stated mention, typescript-is does not support adding nominal types. while typescript does for example:

type USD={id:'usd'} & number
const usd: USD = 5 as USD  // typescript allow this
const x=5;
console.log(is(<USD>(x)) // --> false

Suggested fix

we can notice that every time we intersect an object with primitive type the return type will the primitive type, So simply what I did is return the that primitive type when ever there is intersection between it and any object

@MurhafElmasri MurhafElmasri mentioned this pull request Dec 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MurhafElmasri