feat(helm): allow using config of a router from a file #1961
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noroth
changed the title
maxkomarychev
force-pushed
the
max/embed-config-from-file
branch
from
c2cf1b7 to
d82ca00
Compare
maxkomarychev
changed the title
maxkomarychev
changed the title
maxkomarychev
force-pushed
the
max/embed-config-from-file
branch
from
d82ca00 to
0ac8d3a
Compare
When config gets large it's easier to manage it as an external file: - lint with external tools - get proper syntax support in editors - share the same config across multiple instances of a router
maxkomarychev
force-pushed
the
max/embed-config-from-file
branch
from
0ac8d3a to
7e9f7db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When config gets large it's easier to manage it as an external file:
Checklist
Fixes: #1962