Skip to content

Commit d2dd68e

Browse files
committed
got rid of thiz
1 parent 0919137 commit d2dd68e

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

src/components/graphDiagram/GraphEditor.tsx

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ export interface GraphEditorState {
4141
lastUpdateTime: number;
4242
}
4343

44-
let thiz: GraphEditor;
4544
let svgContainer: any;
4645
let svg: Selection<Element, {}, any, any> | undefined;
4746
let svg_g: Selection<Element, {}, any, any> | undefined;
@@ -68,7 +67,6 @@ export default class GraphEditor extends React.Component<GraphEditorProps, Graph
6867
private _dragged: boolean = false;
6968

7069
componentWillMount() {
71-
thiz = this;
7270
this.setState({
7371
scale: 1.0,
7472
// linkDistance: 100,
@@ -139,7 +137,7 @@ export default class GraphEditor extends React.Component<GraphEditorProps, Graph
139137
initGraphEditor(): void {
140138
this.diagram = new Diagram()
141139
.scaling(null)
142-
.overlay(function (layoutModel: LayoutModel, view: any) {
140+
.overlay((layoutModel: LayoutModel, view: any) => {
143141
// fixes a null reference when dragging
144142
let svgElement: Selection<SVGSVGElement, any, HTMLElement, any> = select<SVGSVGElement, any>('svg');
145143
view = svgElement.select('g.layer.overlay');
@@ -155,8 +153,8 @@ export default class GraphEditor extends React.Component<GraphEditorProps, Graph
155153
var merge = nodeOverlays.merge(nodeOverlaysEnter);
156154

157155
merge
158-
.call(drag().on("start", thiz._dragStartHandler).on("drag", thiz._dragNodeHandler).on("end", thiz._dragEndHandler))
159-
.on("dblclick", thiz._editNodeHandler)
156+
.call(drag().on("start", this._dragStartHandler).on("drag", this._dragNodeHandler).on("end", this._dragEndHandler))
157+
.on("dblclick", this._editNodeHandler)
160158
.attr("r", function (node: LayoutNode) {
161159
return node.radius.outside();
162160
})
@@ -182,7 +180,7 @@ export default class GraphEditor extends React.Component<GraphEditorProps, Graph
182180
var merge = nodeRings.merge(nodeRingsEnter);
183181

184182
merge
185-
.call(drag().on("drag", thiz._dragRingHandler).on("end", thiz._dragEndHandler))
183+
.call(drag().on("drag", this._dragRingHandler).on("end", this._dragEndHandler))
186184
.attr("r", function (node: LayoutNode) {
187185
return node.radius.outside() + 5;
188186
})
@@ -212,7 +210,7 @@ export default class GraphEditor extends React.Component<GraphEditorProps, Graph
212210
.attr("fill", "rgba(255, 255, 255, 0)")
213211
.attr("stroke", "rgba(255, 255, 255, 0)")
214212
.attr("stroke-width", "10px")
215-
.on("dblclick", thiz._editRelationshipHandler)
213+
.on("dblclick", this._editRelationshipHandler)
216214
.attr("transform", function (r: any) {
217215
var angle = r.start.model.angleTo(r.end.model);
218216
return "translate(" + r.start.model.ex() + "," + r.start.model.ey() + ") rotate(" + angle + ")";
@@ -460,8 +458,8 @@ export default class GraphEditor extends React.Component<GraphEditorProps, Graph
460458
this.resetFixedNodes()
461459
}
462460

463-
if (thiz.diagram) {
464-
simData = thiz.generateSimData(thiz.diagram);
461+
if (this.diagram) {
462+
simData = this.generateSimData(this.diagram);
465463
}
466464

467465
if (svg_g) {
@@ -492,14 +490,14 @@ export default class GraphEditor extends React.Component<GraphEditorProps, Graph
492490
.stop()
493491
.on("end", () => {
494492
console.log('simulation: end');
495-
thiz.ended()
493+
this.ended()
496494
})
497495

498496
for (let i = 0; i < preTicks; i++) {
499497
simulation.tick();
500498
}
501499
// this.ticked();
502-
simulation.on('tick', this.ticked)
500+
simulation.on('tick', this.ticked.bind(this))
503501
this.restartSimulation()
504502
}
505503

@@ -525,12 +523,12 @@ export default class GraphEditor extends React.Component<GraphEditorProps, Graph
525523
}
526524

527525
ticked() {
528-
thiz.updateAndRedrawNodes();
526+
this.updateAndRedrawNodes();
529527
}
530528

531529
ended() {
532530
if (simulation) simulation.stop();
533-
thiz.updateAndRedrawNodes();
531+
this.updateAndRedrawNodes();
534532
console.log(`ended:`, simData)
535533
}
536534

0 commit comments

Comments
 (0)