Skip to content

Commit 46d4612

Browse files
committed
fix server version bypass on linking
1 parent a9d36cb commit 46d4612

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

build/Dockerfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ COPY cmd ./cmd
1313
COPY pkg ./pkg
1414
COPY go.mod .
1515
COPY go.sum .
16-
RUN go build -o server -ldflags="-X 'main.Version=$APP_VERSION'" ./cmd/playground && \
16+
ARG APP_VERSION=1.0.0
17+
RUN echo "Building server with version $APP_VERSION" && \
18+
go build -o server -ldflags="-X 'main.Version=$APP_VERSION'" ./cmd/playground && \
1719
GOOS=js GOARCH=wasm go build -o ./worker.wasm ./cmd/webworker && \
1820
cp $(go env GOROOT)/misc/wasm/wasm_exec.js .
1921

cmd/playground/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import (
1818
"go.uber.org/zap"
1919
)
2020

21-
const Version = "testing"
21+
var Version = "testing"
2222

2323
type appArgs struct {
2424
packagesFile string

0 commit comments

Comments
 (0)