Address review

Author: AntoinePrv

include/xsimd/arch/xsimd_avx512f.hpp

@@ -2256,10 +2256,8 @@ namespace xsimd
         {
             static_assert(sizeof...(Values) == batch_bool<T, A>::size, "consistent init");
             using register_type = typename batch_bool<T, A>::register_type;
-            register_type r = 0;
             unsigned shift = 0;
-            ((r |= register_type(values ? 1 : 0) << (shift++)), ...);
-            return r;
+            return (register_type(0) | ... | (register_type(values ? 1 : 0) << (shift++)));
         }
 
         // shuffle

include/xsimd/arch/xsimd_avx512vl_128.hpp

@@ -174,10 +174,8 @@ namespace xsimd
         {
             static_assert(sizeof...(Values) == batch_bool<T, A>::size, "consistent init");
             using register_type = typename batch_bool<T, A>::register_type;
-            register_type r = 0;
             unsigned shift = 0;
-            ((r |= register_type(values ? 1 : 0) << (shift++)), ...);
-            return r;
+            return (register_type(0) | ... | (register_type(values ? 1 : 0) << (shift++)));
         }
 
         // store

include/xsimd/arch/xsimd_avx512vl_256.hpp

@@ -174,10 +174,8 @@ namespace xsimd
         {
             static_assert(sizeof...(Values) == batch_bool<T, A>::size, "consistent init");
             using register_type = typename batch_bool<T, A>::register_type;
-            register_type r = 0;
             unsigned shift = 0;
-            ((r |= register_type(values ? 1 : 0) << (shift++)), ...);
-            return r;
+            return (register_type(0) | ... | (register_type(values ? 1 : 0) << (shift++)));
         }
 
         // store

include/xsimd/utils/bits.hpp

@@ -19,24 +19,24 @@ namespace xsimd
 {
     namespace utils
     {
-        template <typename I, typename... Args>
-        constexpr I make_bit_mask(I bit, Args... bits)
+        template <typename... Args>
+        constexpr auto make_bit_mask(Args... bits)
         {
-            static_assert(std::is_unsigned_v<I>, "Bit operations must be done on unsigned integers");
-            [[maybe_unused]] constexpr I bit_count = static_cast<I>(8 * sizeof(I));
-            assert(((bit < bit_count) && ... && (static_cast<I>(bits) < bit_count)));
-            return static_cast<I>(((I { 1 } << bit) | ... | (I { 1 } << static_cast<I>(bits))));
+            using out_type = std::common_type_t<unsigned short, std::make_unsigned_t<Args>...>;
+            [[maybe_unused]] constexpr auto bit_count = static_cast<out_type>(8 * sizeof(out_type));
+            assert((((static_cast<out_type>(bits) < bit_count) && ...)));
+            return static_cast<out_type>((0u | ... | (1u << bits)));
         }
 
-        template <int... Bits, typename I>
+        template <auto... Bits, typename I>
         constexpr bool all_bits_set(I value)
         {
             static_assert(std::is_unsigned_v<I>, "Bit operations must be done on unsigned integers");
             constexpr I mask = make_bit_mask<I>(static_cast<I>(Bits)...);
             return (value & mask) == mask;
         }
 
-        template <int Bit, typename I>
+        template <auto Bit, typename I>
         constexpr I set_bit(I value)
         {
             static_assert(std::is_unsigned_v<I>, "Bit operations must be done on unsigned integers");

test/test_utils_bits.cpp

@@ -17,6 +17,8 @@
 
 TEST_CASE("[utils::make_bit_mask] single bit")
 {
+    CHECK_EQ(xsimd::utils::make_bit_mask(), 0x0);
+    CHECK_EQ(xsimd::utils::make_bit_mask(1), 0b0010);
     CHECK_EQ(xsimd::utils::make_bit_mask<std::uint8_t>(0), 0x01);
     CHECK_EQ(xsimd::utils::make_bit_mask<std::uint8_t>(7), 0x80);
     CHECK_EQ(xsimd::utils::make_bit_mask<std::uint32_t>(0), 0x01u);