Make register class implementation private

Author: AntoinePrv

include/xsimd/config/xsimd_cpu_features_x86.hpp

@@ -45,18 +45,6 @@ namespace xsimd
     class x86_xcr0
     {
     public:
-        using reg_t = detail::xcr0_reg_t;
-
-        static constexpr reg_t sse_bit = 1;
-        static constexpr reg_t avx_bit = 2;
-        static constexpr reg_t avx512_bit = 6;
-
-        /** Parse a XCR0 value into individual components. */
-        constexpr explicit x86_xcr0(reg_t low) noexcept
-            : m_low(low)
-        {
-        }
-
         /**
          * Create a default value with only SSE enabled.
          *
@@ -78,6 +66,9 @@ namespace xsimd
             return x86_xcr0(detail::get_xcr0_low());
         }
 
+        /** Create a value which return false to everything. */
+        constexpr x86_xcr0() noexcept = default;
+
         constexpr bool sse_enabled() const noexcept
         {
             return utils::bit_is_set<sse_bit>(m_low);
@@ -97,6 +88,17 @@ namespace xsimd
         }
 
     private:
+        using reg_t = detail::xcr0_reg_t;
+
+        static constexpr reg_t sse_bit = 1;
+        static constexpr reg_t avx_bit = 2;
+        static constexpr reg_t avx512_bit = 6;
+
+        /** Parse a XCR0 value into individual components. */
+        constexpr explicit x86_xcr0(reg_t low) noexcept
+            : m_low(low)
+        {
+        }
         reg_t m_low = {};
     };
 
@@ -112,22 +114,6 @@ namespace xsimd
     class x86_cpu_id
     {
     public:
-        struct cpu_id_regs
-        {
-            using reg_t = detail::cpuid_reg_t;
-
-            reg_t reg1 = {};
-            reg_t reg7 = {};
-            reg_t reg7a = {};
-            reg_t reg8 = {};
-        };
-
-        /** Parse CpuInfo register values into individual components. */
-        constexpr explicit x86_cpu_id(const cpu_id_regs& regs) noexcept
-            : m_regs(regs)
-        {
-        }
-
         /**
          * Read the CpuId registers from the CPU if on the correct architecture.
          *
@@ -146,6 +132,9 @@ namespace xsimd
             return x86_cpu_id(regs);
         }
 
+        /** Create a value which return false to everything. */
+        constexpr x86_cpu_id() noexcept = default;
+
         constexpr bool sse2() const noexcept { return utils::bit_is_set<26>(m_regs.reg1[3]); }
 
         constexpr bool sse3() const noexcept { return utils::bit_is_set<0>(m_regs.reg1[2]); }
@@ -199,6 +188,21 @@ namespace xsimd
         constexpr bool fma4() const noexcept { return utils::bit_is_set<16>(m_regs.reg8[2]); }
 
     private:
+        struct cpu_id_regs
+        {
+            using reg_t = detail::cpuid_reg_t;
+
+            reg_t reg1 = {};
+            reg_t reg7 = {};
+            reg_t reg7a = {};
+            reg_t reg8 = {};
+        };
+
+        /** Parse CpuInfo register values into individual components. */
+        constexpr explicit x86_cpu_id(const cpu_id_regs& regs) noexcept
+            : m_regs(regs)
+        {
+        }
         cpu_id_regs m_regs = {};
     };