XWIKI-17700: Information tab doesn't show the right current locale when locale is none

* Pass the language parameter when requesting the document extra tabs
* Show a warning when a document with no language set has translations
* Don't show the Translate button for pages with no language set if the existing translations are for unsupported locales.
* Don't show the create translation links if the default translation has no language set.

Author: mflorea

xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/menus_content.vm

@@ -59,15 +59,18 @@
     ## * multilingual is on
     ## * the user can edit the current document
     ## * the user is viewing the original document version
-    ## * the document is translatable (either has a default locale specified or it has existing translations)
-    ## * the current UI locale doesn't match the original document locale
+    ## * the document is translatable (either has a default locale specified or it has existing translations for the
+    ##   supported locales)
+    ## * the current UI locale doesn't match the original document locale, and there's no existing translation for it
+    #set ($supportedTranslationLocales = $doc.translationLocales)
+    #set ($discard = $supportedTranslationLocales.retainAll($xwiki.availableLocales))
     #if (
       $displayTranslateMenu &&
       $xwiki.isMultiLingual() &&
       $hasEdit && !$isReadOnly &&
       $xcontext.action == 'view' && $tdoc.realLocale == $doc.realLocale &&
-      ("$!doc.realLocale" != '' || !$doc.translationLocales.isEmpty()) &&
-      $doc.realLocale != $xcontext.locale
+      ("$!doc.realLocale" != '' || !$supportedTranslationLocales.isEmpty()) &&
+      $doc.realLocale != $xcontext.locale && !$supportedTranslationLocales.contains($xcontext.locale)
     )
       #displayTranslateMenu()
     #end

xwiki-platform-core/xwiki-platform-oldcore/src/main/resources/ApplicationResources.properties

@@ -1213,6 +1213,7 @@ core.viewers.history.empty="The history of this page is empty."
 core.viewers.information.title=Information about <a href="{1}">{0}</a>
 core.viewers.information.locale=Language
 core.viewers.information.noLocale=None
+core.viewers.information.noLocaleWarning=A page with no language set shouldn't have translations.
 core.viewers.information.originalLocale=Default language
 core.viewers.information.translations=Translations
 core.viewers.information.syntax=Syntax

xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/display_macros.vm

@@ -73,13 +73,15 @@
   #foreach ($translationLocale in $doc.translationLocales)
     #set ($discard = $macro.disabledLocales.add("$translationLocale"))
   #end
+  ## Allow selecting no locale if there are no document translations or there is already no locale selected.
+  #set ($macro.allowEmpty = $doc.translationLocales.isEmpty() || "$!tdoc.defaultLocale" == '')
   #set ($macro.parameters = {
     'id': 'xwikidoclanguageinput2',
     'name': 'defaultLanguage',
     'value': $tdoc.defaultLocale,
     'mode': $displayMode,
     'settings': {
-      'allowEmpty': $doc.translationLocales.isEmpty(),
+      'allowEmpty': $macro.allowEmpty,
       'supportedLocales': $macro.supportedLocales,
       'disabledLocales':$macro.disabledLocales,
       'disabledLocalesHint': $services.localization.render('web.templates.documentLocalePicker.existingTranslation')

xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/informationinline.vm

@@ -19,6 +19,7 @@
 ## ---------------------------------------------------------------------------
 #template('display_macros.vm')
 #initRequiredSkinExtensions()
+
 #macro(docTranslationLink $locale $action $fragment)
   #set ($localeName = $locale.getDisplayName($xcontext.locale))
   #if ("$!localeName" == '')
@@ -32,6 +33,15 @@
   #end
   <a href="$translationURL" data-locale="$escapetool.xml($locale)">$escapetool.xml($localeName)</a>
 #end
+
+#macro (_maybeShowNoLocaleWarning)
+  #if ("$!doc.realLocale" == '')
+    <span title="$escapetool.xml($services.localization.render('core.viewers.information.noLocaleWarning'))">
+      $services.icon.renderHTML('warning')
+    </span>
+  #end
+#end
+
 $xwiki.jsfx.use('js/xwiki/viewers/information.js', {'forceSkinAction': true, 'language': ${xcontext.locale}})
 $xwiki.ssfx.use('js/xwiki/viewers/information.css', true)
 $xwiki.jsfx.use('uicomponents/edit/editableProperty.js', {'forceSkinAction': true, 'language': $xcontext.locale})
@@ -60,6 +70,7 @@ $xwiki.jsfx.use('uicomponents/edit/editableProperty.js', {'forceSkinAction': tru
   #set ($discard = $staticUIX.add({'content': "
     <dt>
       <label>$escapetool.xml($services.localization.render('core.viewers.information.originalLocale'))</label>
+      #_maybeShowNoLocaleWarning()
     </dt>
     <dd data-key=""originalLocale"">#docTranslationLink($doc.realLocale 'view')</dd>
     ",
@@ -71,40 +82,40 @@ $xwiki.jsfx.use('uicomponents/edit/editableProperty.js', {'forceSkinAction': tru
 ## Translations
 ##
 #set ($existingTranslations = $doc.translationLocales)
-## Show the list of translations if multilingual is on and either the original page is translatable (has a
-## locale specified) or it has existing translations.
-#if ($xwiki.isMultiLingual() && ("$!doc.realLocale" != '' || !$existingTranslations.isEmpty()))
+## Show the list of translations if multilingual is on.
+#if ($xwiki.isMultiLingual())
   #set ($supportedLocales = $xwiki.availableLocales)
   ## Remove the translations that we already display above.
   #set ($discard = $supportedLocales.remove($tdoc.realLocale))
   #set ($discard = $supportedLocales.remove($doc.realLocale))
-  #if (!$supportedLocales.isEmpty())
-    #set ($output = [])
-    #foreach ($supportedLocale in $supportedLocales)
-      #if ($existingTranslations.contains($supportedLocale))
-        #set ($discard = $output.add($stringtool.trim("#docTranslationLink($supportedLocale 'view')")))
-      #elseif ($hasEdit)
-        ## Show the link to create the missing translation if the current user can edit the page. Use the
-        ## preferred edit mode (in-place versus stand-alone) depending on the user preferences, in order to
-        ## replicate the behavior of the Translate button.
-        #set ($action = 'edit')
-        #set ($fragment = $NULL)
-        #getDefaultDocumentEditor($defaultEditMode)
-        #if ($services.edit.document.inPlaceEditingEnabled() && $defaultEditMode == 'wysiwyg')
-          ## Link to the in-place page editor which currently uses the view action.
-          #set ($action = 'view')
-          #set ($fragment = 'translate')
-        #end
-        #set ($discard = $output.add(
-          "<span class='wikicreatelink skipCreatePagePopup'>" +
-            $stringtool.trim("#docTranslationLink($supportedLocale $action $fragment)") +
-          "</span>"
-        ))
+  #set ($output = [])
+  #foreach ($supportedLocale in $supportedLocales)
+    #if ($existingTranslations.contains($supportedLocale))
+      #set ($discard = $output.add($stringtool.trim("#docTranslationLink($supportedLocale 'view')")))
+    #elseif ($hasEdit && "$!doc.realLocale" != '')
+      ## Show the link to create the missing translation if the current user can edit the page and the default
+      ## translation has a locale set (i.e. if the page can be translated). Use the preferred edit mode (in-place versus
+      ## stand-alone) depending on the user preferences, in order to replicate the behavior of the Translate button.
+      #set ($action = 'edit')
+      #set ($fragment = $NULL)
+      #getDefaultDocumentEditor($defaultEditMode)
+      #if ($services.edit.document.inPlaceEditingEnabled() && $defaultEditMode == 'wysiwyg')
+        ## Link to the in-place page editor which currently uses the view action.
+        #set ($action = 'view')
+        #set ($fragment = 'translate')
       #end
+      #set ($discard = $output.add(
+        "<span class='wikicreatelink skipCreatePagePopup'>" +
+          $stringtool.trim("#docTranslationLink($supportedLocale $action $fragment)") +
+        "</span>"
+      ))
     #end
+  #end
+  #if (!$output.isEmpty())
     #set ($discard = $staticUIX.add({'content': "
       <dt>
         <label>$escapetool.xml($services.localization.render('core.viewers.information.translations'))</label>
+        #_maybeShowNoLocaleWarning()
       </dt>
       <dd data-key=""translations"">$stringtool.join($output, ', ')</dd>
       ",

xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/xwiki.js

@@ -210,17 +210,22 @@ Object.extend(XWiki, {
         }
         $("docextrapanes").className="loading";
 
-        // Determine if JS minification is disabled in the URL. Needed to pass it to the AJAX call to get the right resources on the reply.
-        var maybeMinifyRequestParameter = '';
-        var requestMinify = window.location.search.toQueryParams().minify;
-        if (requestMinify && requestMinify == 'false') {
-          maybeMinifyRequestParameter = '&minify=false';
+        const parameters = {
+          'xpage': 'xpart',
+          'vm': extraTemplate,
+          'language': document.documentElement.dataset.xwikiLocale
+        };
+        // Determine if JavaScript minification is disabled from the URL. We need to pass it to the AJAX call in order
+        // to get the right resources on the response.
+        if (new URLSearchParams(window.location.search).get('minify') === 'false') {
+          parameters.minify = 'false';
         }
 
         new Ajax.Request(
-          window.docgeturl + '?xpage=xpart&vm=' + extraTemplate + maybeMinifyRequestParameter,
+          window.docgeturl,
                 {
                     method: 'get',
+                    parameters,
                     onSuccess: function(response) {
                       // Do the work that Ajax.Updater is supposed to do, but we can't use it because it strips the <script>s
                       // from the output and we need to inject the external scripts from the reply (in the DOM's dead), to execute them.