feat(logical-support): add sse_c support to aws s3 cp #2926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslafy-z
requested review from
FxKu,
Jan-M,
hughcapet,
idanovinda,
jopadi,
macedigital and
sdudoladov
as code owners
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
1 similar comment
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
Signed-off-by: Zadkiel AHARONIAN <[email protected]>
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
|
@FxKu Hello, any chance this PR gets reviewed and merged anytime soon? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws s3 cpneeds--sse-cand--sse-c-keyargs work with SSE-C.LOGICAL_BACKUP_S3_SSE_CandLOGICAL_BACKUP_S3_SSE_C_KEYwas added to the backup script.These new variables can be passed to logical_backup using
logical_backup_cronjob_environment_secret.