Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Commit 598e20d

Browse files
committed
Removed shareByDefault() implementation
From what I can tell, it was added for purposes of testing; I updated the test to use `assertAttributeSame`, varying the property to test against based on SM version.
1 parent 41c30e2 commit 598e20d

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

src/InputFilterPluginManager.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,4 @@ public function validatePlugin($plugin)
158158
throw new Exception\RuntimeException($e->getMessage(), $e->getCode(), $e);
159159
}
160160
}
161-
162-
public function shareByDefault()
163-
{
164-
return $this->sharedByDefault;
165-
}
166161
}

test/InputFilterPluginManagerTest.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,11 @@ public function testIsASubclassOfAbstractPluginManager()
5252

5353
public function testIsNotSharedByDefault()
5454
{
55-
$this->assertFalse($this->manager->shareByDefault());
55+
$property = method_exists($this->manager, 'configure')
56+
? 'sharedByDefault' // v3
57+
: 'shareByDefault'; // v2
58+
59+
$this->assertAttributeSame(false, $property, $this->manager);
5660
}
5761

5862
public function testRegisteringInvalidElementRaisesException()

0 commit comments

Comments
 (0)