Fix HeaderValue throwing an exception on legal characters

- Changes the ASCII out-of-range checks to use `> 127` instead of `>
  126`, as 127 is the last ASCII character.
- Removed the `testCannotBeConstructed()` test case, as irrelevant.
- Added a data provider to test that wrapping header lines using
  `\r\n\t` is valid. It failed, and, as such, I updated the `isValid()`
  code to check for both ASCII 32 (SP) and 9 (TAB) when checking for
  line wrapping.

Author: MellieVT

.php_cs

@@ -1,5 +1,7 @@
 <?php
 $finder = Symfony\CS\Finder\DefaultFinder::create()
+    ->in('src')
+    ->in('test')
     ->notPath('TestAsset')
     ->notPath('_files')
     ->filter(function (SplFileInfo $file) {

src/Header/HeaderValue.php

@@ -28,20 +28,18 @@ private function __construct()
     public static function filter($value)
     {
         $result = '';
-        $tot    = strlen($value);
+        $total  = strlen($value);
 
         // Filter for CR and LF characters, leaving CRLF + WSP sequences for
         // Long Header Fields (section 2.2.3 of RFC 2822)
-        for ($i = 0; $i < $tot; $i += 1) {
+        for ($i = 0; $i < $total; $i += 1) {
             $ord = ord($value[$i]);
-            if (($ord < 32 || $ord > 126)
-                && $ord !== 13
-            ) {
+            if ($ord === 10 || $ord > 127) {
                 continue;
             }
 
             if ($ord === 13) {
-                if ($i + 2 >= $tot) {
+                if ($i + 2 >= $total) {
                     continue;
                 }
 
@@ -72,27 +70,28 @@ public static function filter($value)
      */
     public static function isValid($value)
     {
-        $tot = strlen($value);
-        for ($i = 0; $i < $tot; $i += 1) {
+        $total = strlen($value);
+        for ($i = 0; $i < $total; $i += 1) {
             $ord = ord($value[$i]);
-            if (($ord < 32 || $ord > 126)
-                && $ord !== 13
-            ) {
+
+            // bare LF means we aren't valid
+            if ($ord === 10 || $ord > 127) {
                 return false;
             }
 
             if ($ord === 13) {
-                if ($i + 2 >= $tot) {
+                if ($i + 2 >= $total) {
                     return false;
                 }
 
                 $lf = ord($value[$i + 1]);
                 $sp = ord($value[$i + 2]);
 
-                if ($lf !== 10 || $sp !== 32) {
+                if ($lf !== 10 || ! in_array($sp, [9, 32], true)) {
                     return false;
                 }
 
+                // skip over the LF following this
                 $i += 2;
             }
         }

test/Header/ContentTypeTest.php

@@ -10,9 +10,6 @@
 namespace ZendTest\Mail\Header;
 
 use Zend\Mail\Header\ContentType;
-use Zend\Mail\Header\Exception\InvalidArgumentException;
-use Zend\Mail\Header\HeaderInterface;
-use Zend\Mail\Header\UnstructuredInterface;
 
 /**
  * @group      Zend_Mail

test/Header/HeaderValueTest.php

@@ -30,7 +30,8 @@ public function getFilterValues()
             array("This is a\r\r test", "This is a test"),
             array("This is a \r\r\n test", "This is a \r\n test"),
             array("This is a \r\n\r\ntest", "This is a test"),
-            array("This is a \r\n\n\r\n test", "This is a \r\n test")
+            array("This is a \r\n\n\r\n test", "This is a \r\n test"),
+            array("This is a test\r\n", "This is a test"),
         );
     }
 
@@ -50,13 +51,18 @@ public function validateValues()
             array("This is a\r test", 'assertFalse'),
             array("This is a\n\r test", 'assertFalse'),
             array("This is a\r\n  test", 'assertTrue'),
+            array("This is a\r\n\ttest", 'assertTrue'),
             array("This is a \r\ntest", 'assertFalse'),
             array("This is a \r\n\n test", 'assertFalse'),
             array("This is a\n\n test", 'assertFalse'),
             array("This is a\r\r test", 'assertFalse'),
             array("This is a \r\r\n test", 'assertFalse'),
             array("This is a \r\n\r\ntest", 'assertFalse'),
-            array("This is a \r\n\n\r\n test", 'assertFalse')
+            array("This is a \r\n\n\r\n test", 'assertFalse'),
+            array("This\tis\ta test", 'assertTrue'),
+            array("This is\ta \r\n test", 'assertTrue'),
+            array("This\tis\ta\ntest", 'assertFalse'),
+            array("This is a \r\t\n \r\n test", 'assertFalse'),
         );
     }
 
@@ -81,7 +87,7 @@ public function assertValues()
             array("This is a\r\r test"),
             array("This is a \r\r\n test"),
             array("This is a \r\n\r\ntest"),
-            array("This is a \r\n\n\r\n test")
+            array("This is a \r\n\n\r\n test"),
         );
     }
 

test/MessageTest.php

@@ -763,7 +763,7 @@ public function testHeaderUnfoldingWorksAsExpectedForMultipartMessages()
         $text->encoding = Mime::ENCODING_QUOTEDPRINTABLE;
         $text->disposition = Mime::DISPOSITION_INLINE;
         $text->charset = 'UTF-8';
-        
+
         $html = new MimePart('<b>Test content</b>');
         $html->type = Mime::TYPE_HTML;
         $html->encoding = Mime::ENCODING_QUOTEDPRINTABLE;