From 50652e5f4a2ae4a27c6baf26768df9d1626ddce7 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Fri, 2 Mar 2018 04:14:33 +0700 Subject: [PATCH 1/4] remove Null Tranport --- src/Transport/Null.php | 35 ----------------------------------- 1 file changed, 35 deletions(-) delete mode 100644 src/Transport/Null.php diff --git a/src/Transport/Null.php b/src/Transport/Null.php deleted file mode 100644 index 266463de..00000000 --- a/src/Transport/Null.php +++ /dev/null @@ -1,35 +0,0 @@ - Date: Fri, 2 Mar 2018 04:17:13 +0700 Subject: [PATCH 2/4] remove also "null" from Factory classMap --- src/Transport/Factory.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Transport/Factory.php b/src/Transport/Factory.php index ff974fb3..fa7d4e8d 100644 --- a/src/Transport/Factory.php +++ b/src/Transport/Factory.php @@ -21,7 +21,6 @@ abstract class Factory 'file' => 'Zend\Mail\Transport\File', 'inmemory' => 'Zend\Mail\Transport\InMemory', 'memory' => 'Zend\Mail\Transport\InMemory', - 'null' => 'Zend\Mail\Transport\InMemory', 'sendmail' => 'Zend\Mail\Transport\Sendmail', 'smtp' => 'Zend\Mail\Transport\Smtp', ]; From 2f7aacb8624b601bfa59b019805190ec82e3be5a Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Fri, 2 Mar 2018 04:19:04 +0700 Subject: [PATCH 3/4] test update for removing Null transport --- test/Transport/FactoryTest.php | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/test/Transport/FactoryTest.php b/test/Transport/FactoryTest.php index a605e163..0b1f97be 100644 --- a/test/Transport/FactoryTest.php +++ b/test/Transport/FactoryTest.php @@ -71,10 +71,6 @@ public function typeProvider() ['Zend\Mail\Transport\Smtp'], ]; - if (version_compare(PHP_VERSION, '7.0', '<')) { - $types[] = ['Zend\Mail\Transport\Null']; - } - return $types; } @@ -96,15 +92,12 @@ public function typeAliasProvider() { return [ ['file', 'Zend\Mail\Transport\File'], - ['null', 'Zend\Mail\Transport\InMemory'], ['memory', 'Zend\Mail\Transport\InMemory'], ['inmemory', 'Zend\Mail\Transport\InMemory'], ['InMemory', 'Zend\Mail\Transport\InMemory'], ['sendmail', 'Zend\Mail\Transport\Sendmail'], ['smtp', 'Zend\Mail\Transport\Smtp'], ['File', 'Zend\Mail\Transport\File'], - ['Null', 'Zend\Mail\Transport\InMemory'], - ['NULL', 'Zend\Mail\Transport\InMemory'], ['Sendmail', 'Zend\Mail\Transport\Sendmail'], ['SendMail', 'Zend\Mail\Transport\Sendmail'], ['Smtp', 'Zend\Mail\Transport\Smtp'], @@ -118,7 +111,7 @@ public function typeAliasProvider() public function testCanUseTraversableAsSpec() { $spec = new ArrayObject([ - 'type' => 'null' + 'type' => 'inMemory' ]); $transport = Factory::create($spec); From 7471979fa12b72594cab78ec4dfff6cac00bde92 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Fri, 2 Mar 2018 04:20:07 +0700 Subject: [PATCH 4/4] remove NullTest --- test/Transport/NullTest.php | 32 -------------------------------- 1 file changed, 32 deletions(-) delete mode 100644 test/Transport/NullTest.php diff --git a/test/Transport/NullTest.php b/test/Transport/NullTest.php deleted file mode 100644 index f563a448..00000000 --- a/test/Transport/NullTest.php +++ /dev/null @@ -1,32 +0,0 @@ -=')) { - $this->markTestSkipped('Cannot test Null transport under PHP 7; reserved keyword'); - } - } - - public function testRaisesNoticeOnInstantiation() - { - $this->expectException('PHPUnit_Framework_Error_Deprecated'); - new NullTransport(); - } -}