Update for 0.15.x, update tracy to 0.12.4 #9
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Update build.zig
- Bump minimum zig version, for std.fmt usage
|
Missing update to the readme 👀 |
src/ztracy.zig
Outdated
|
|
||
| pub const AppInfo = if (enabled) impl.AppInfo else stub.AppInfo; | ||
|
|
||
| pub const TracyAllocator = if (enabled) impl.AppInfo else stub.AppInfo; |
There was a problem hiding this comment.
This is incorrect, it should be
pub const TracyAllocator = if (enabled) impl.TracyAllocator else stub.TracyAllocator;
|
@hazeycode other than my previous comment, is there anything else blocking this PR from being merged? |
There was a problem hiding this comment.
Pull Request Overview
This PR updates Tracy to version 0.12.4 and removes deprecated usingnamespace usage to ensure compatibility with Zig 0.15.x. The update includes refactoring the code structure to use explicit imports instead of namespacing, and updating build configuration.
Key changes:
- Update Tracy from version 0.11.1 to 0.12.4 with numerous new features and improvements
- Replace
usingnamespacewith explicit function declarations to maintain API compatibility - Refactor code organization by splitting functionality into separate stub.zig and impl.zig files
Reviewed Changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ztracy.zig | Removes usingnamespace and replaces with explicit function declarations, splits implementation into separate files |
| src/stub.zig | Contains stub implementations for when Tracy is disabled |
| src/impl.zig | Contains full Tracy implementation when enabled |
| libs/tracy/* | Updates Tracy library to version 0.12.4 with numerous enhancements and bug fixes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Looks good other than the TracyAllocator definition |
Co-authored-by: Copilot <[email protected]>
|
Wops. Did not notice before now. The tracy version is invalid. 0.12.4 does not exist and it seems to not be introducing either 0.12, 0.12.1 or 0.12.2. @kcbanner what am I missing here? |
I used the version from enum { Minor = 12 };
enum { Patch = 4 };I assumed that was the most recently released version, but you are correct, 0.12.2 was the most recently released and 0.12.4 hasn't been released yet. |
|
Makes sense. Thanks for the good work on the PR! ❤️ |
Uh oh!
There was an error while loading. Please reload this page.