Stability Issues Addressed

[pnpebeling]

Hi,

I'm experiencing stability issues which I believe are related to thread safety. During extended run testing I have experienced exceptions related to the (Driver) Callbacks Dictionary and (what I believe are) some web-socket related hangs, though I have no "smoking-gun" to prove this theory. I have addressed these issues as follows:

The Callbacks dictionary is defined as a simple Dictionary Dictionary<Guid, Action> which provides no thread safety. Since this construct is referenced both when callbacks are added and completed, I felt that some form of thread safety was required. I have implemented a replacement class that wraps a CurrentDictionary exposing only the required Dictionary methods.

As to the (presumed) web-socket hangs, I noticed the use of the SendInstant method. The comments warn of issues with simultaneous access. Since my calling framework is multi-threaded, I made a simple change to the WebcocketClient, SendInstant methods to force synchronization around a lock object.

Its fairly early in my testing, but these changes seem to have addressed the stability issues.

-p

[marcus-j-davies]

Hi @pnpebeling
Do you want to provide a Pull Request?

I can then review it, and get it merged into the v4 branch?

[pnpebeling]

Sure ... What I have is preliminary, I'd like it to run a while longer to be sure of the potential fixes. When I'm a bit more confident, I'll clean it up and do the Pull.

-p