Skip to content

Require 'static lifetime for CompletionModel #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Require 'static lifetime for CompletionModel #1049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rig-core/src/client/completion.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ use std::sync::Arc;
/// Clone is required for conversions between client types.
pub trait CompletionClient: ProviderClient + Clone {
/// The type of CompletionModel used by the client.
type CompletionModel: CompletionModel;
// require the associated CompletionModel to be 'static so it can be used
Copy link
Collaborator

@joshua-mo-143 joshua-mo-143 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the original docstring here and move this detail to the trait docstrings rather than having it here

// behind trait objects (Box/Arc<dyn ... + 'static>) safely
type CompletionModel: CompletionModel + 'static;

/// Create a completion model with the given name.
///
Expand Down