fix(commands,deploy): use node + ejs:github for YouTube n-challenge; set cookies env

yt-dlp now requires an explicit JS runtime (--js-runtimes node) and the
EJS challenge solver script (--remote-components ejs:github) to decode
YouTube streaming URLs. Without these, all formats are dropped.

Also add YT_DLP_COOKIES_PATH to supervisor env — it was never set so
the bot was running every download unauthenticated.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: 1Git2Clone

deploy/supervisor/serenity-bot.conf

@@ -15,7 +15,7 @@
 [program:serenity-bot-a-blue]
 command=/home/hutao/serenity-discord-bot/target/release/serenity-discord-bot
 directory=/home/hutao/serenity-discord-bot
-environment=RUST_LOG="warn,serenity_discord_bot=info",TOTAL_SHARDS="16",SHARD_START="0",SHARD_END="7",PATH="/home/%(ENV_USER)s/.deno/bin:/home/%(ENV_USER)s/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
+environment=RUST_LOG="warn,serenity_discord_bot=info",TOTAL_SHARDS="16",SHARD_START="0",SHARD_END="7",PATH="/home/%(ENV_USER)s/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",YT_DLP_COOKIES_PATH="/home/%(ENV_USER)s/serenity-discord-bot/cookies.txt"
 autostart=true
 autorestart=true
 stdout_logfile=/var/log/serenity-bot/a-blue-stdout.log
@@ -28,7 +28,7 @@ stderr_logfile_backups=3
 [program:serenity-bot-a-green]
 command=/home/hutao/serenity-discord-bot/target/release/serenity-discord-bot
 directory=/home/hutao/serenity-discord-bot
-environment=RUST_LOG="warn,serenity_discord_bot=info",TOTAL_SHARDS="16",SHARD_START="0",SHARD_END="7",PATH="/home/%(ENV_USER)s/.deno/bin:/home/%(ENV_USER)s/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
+environment=RUST_LOG="warn,serenity_discord_bot=info",TOTAL_SHARDS="16",SHARD_START="0",SHARD_END="7",PATH="/home/%(ENV_USER)s/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",YT_DLP_COOKIES_PATH="/home/%(ENV_USER)s/serenity-discord-bot/cookies.txt"
 autostart=false
 autorestart=true
 stdout_logfile=/var/log/serenity-bot/a-green-stdout.log
@@ -41,7 +41,7 @@ stderr_logfile_backups=3
 [program:serenity-bot-b-blue]
 command=/home/hutao/serenity-discord-bot/target/release/serenity-discord-bot
 directory=/home/hutao/serenity-discord-bot
-environment=RUST_LOG="warn,serenity_discord_bot=info",TOTAL_SHARDS="16",SHARD_START="8",SHARD_END="15",PATH="/home/%(ENV_USER)s/.deno/bin:/home/%(ENV_USER)s/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
+environment=RUST_LOG="warn,serenity_discord_bot=info",TOTAL_SHARDS="16",SHARD_START="8",SHARD_END="15",PATH="/home/%(ENV_USER)s/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",YT_DLP_COOKIES_PATH="/home/%(ENV_USER)s/serenity-discord-bot/cookies.txt"
 autostart=true
 autorestart=true
 stdout_logfile=/var/log/serenity-bot/b-blue-stdout.log
@@ -54,7 +54,7 @@ stderr_logfile_backups=3
 [program:serenity-bot-b-green]
 command=/home/hutao/serenity-discord-bot/target/release/serenity-discord-bot
 directory=/home/hutao/serenity-discord-bot
-environment=RUST_LOG="warn,serenity_discord_bot=info",TOTAL_SHARDS="16",SHARD_START="8",SHARD_END="15",PATH="/home/%(ENV_USER)s/.deno/bin:/home/%(ENV_USER)s/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
+environment=RUST_LOG="warn,serenity_discord_bot=info",TOTAL_SHARDS="16",SHARD_START="8",SHARD_END="15",PATH="/home/%(ENV_USER)s/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",YT_DLP_COOKIES_PATH="/home/%(ENV_USER)s/serenity-discord-bot/cookies.txt"
 autostart=false
 autorestart=true
 stdout_logfile=/var/log/serenity-bot/b-green-stdout.log

src/commands/util/download.rs

@@ -302,17 +302,6 @@ pub async fn download(
     ctx.say("Downloading media...").await?;
 
     let mut cmd = Command::new("yt-dlp");
-
-    // Supervisor strips most of HOME-relative PATH entries. Prepend common
-    // JS runtime locations so yt-dlp can solve YouTube's n-challenge.
-    if let Ok(home) = std::env::var("HOME") {
-        let current = std::env::var("PATH").unwrap_or_default();
-        cmd.env(
-            "PATH",
-            format!("{home}/.deno/bin:{home}/.local/bin:/usr/local/bin:/usr/bin:/bin:{current}"),
-        );
-    }
-
     cmd.arg("--no-playlist")
         // `--print` alone implies `--simulate` (nothing downloads), and the
         // bare `filename` field is the pre-merge name. `--no-simulate` plus
@@ -321,6 +310,10 @@ pub async fn download(
         // Prefer mp4/m4a but fall back to whatever's available.
         .args(["-S", "+ext:mp4:m4a"])
         .args(["--merge-output-format", "mp4"])
+        // Use node for JS challenge solving (n-challenge + signature).
+        // ejs:github fetches the required solver script on first use.
+        .args(["--js-runtimes", "node"])
+        .args(["--remote-components", "ejs:github"])
         .args(["--print", "after_move:filepath"])
         .arg("--output")
         .arg(source_template.to_string_lossy().to_string());