Merge pull request #319 from 7-umc-GrowIT/refactor/#318

[#318] Refactor: 챌린지 삭제 api 응답 반환 수정

Author: HSSJW

config

@@ -152,14 +152,6 @@ public static ChallengeResponseDTO.ModifyProofDTO toChallengeModifyProofDTO(User
                 .build();
     }
 
-    // 챌린지 삭제
-    public static ChallengeResponseDTO.DeleteChallengeResponseDTO toDeletedUserChallenge(UserChallenge userChallenge) {
-        return ChallengeResponseDTO.DeleteChallengeResponseDTO.builder()
-                .id(userChallenge.getId())
-                .message("챌린지를 삭제했어요")
-                .build();
-    }
-
     public static List<ChallengeResponseDTO.ChallengeDTO> toRecommendedChallenges(List<Challenge> dailyChallenges, Challenge randomChallenge) {
         // daily 챌린지 변환
         List<ChallengeResponseDTO.ChallengeDTO> recommendedChallenges = dailyChallenges.stream()

src/main/java/umc/GrowIT/Server/converter/ChallengeConverter.java

@@ -4,13 +4,12 @@
 import umc.GrowIT.Server.web.dto.ChallengeDTO.ChallengeResponseDTO;
 
 import java.util.List;
-import java.util.Map;
 
 public interface ChallengeCommandService {
 
     ChallengeResponseDTO.SelectChallengeResponseDTO selectChallenges(Long userId, List<ChallengeRequestDTO.SelectChallengeRequestDTO> selectRequestList);
     ChallengeResponseDTO.ProofPresignedUrlResponseDTO createChallengePresignedUrl(Long userId, ChallengeRequestDTO.ProofRequestPresignedUrlDTO request);
     ChallengeResponseDTO.CreateProofDTO createChallengeProof(Long userId, Long userChallengeId, ChallengeRequestDTO.ProofRequestDTO proofRequest);
     ChallengeResponseDTO.ModifyProofDTO updateChallengeProof(Long userId, Long userChallengeId, ChallengeRequestDTO.ProofRequestDTO updateRequest);
-    ChallengeResponseDTO.DeleteChallengeResponseDTO delete(Long userChallengeId, Long userId);
+    void delete(Long userChallengeId, Long userId);
 }

src/main/java/umc/GrowIT/Server/service/challengeService/ChallengeCommandService.java

@@ -170,7 +170,7 @@ public ChallengeResponseDTO.ModifyProofDTO updateChallengeProof(Long userId, Lon
 
     // 삭제
     @Override
-    public ChallengeResponseDTO.DeleteChallengeResponseDTO delete(Long userChallengeId, Long userId) {
+    public void delete(Long userChallengeId, Long userId) {
         // 1. userId를 조회하고 없으면 오류
         userRepository.findById(userId)
                 .orElseThrow(() -> new UserHandler(ErrorStatus.USER_NOT_FOUND));
@@ -186,8 +186,5 @@ public ChallengeResponseDTO.DeleteChallengeResponseDTO delete(Long userChallenge
 
         // 4. 삭제
         userChallengeRepository.deleteById(userChallengeId);
-
-        // 5. converter 작업
-        return ChallengeConverter.toDeletedUserChallenge(userChallenge);
     }
 }

src/main/java/umc/GrowIT/Server/service/challengeService/ChallengeCommandServiceImpl.java

@@ -98,12 +98,12 @@ public ApiResponse<ChallengeResponseDTO.ModifyProofDTO> updateChallengeProof(@Pa
     }
 
     @DeleteMapping("{userChallengeId}")
-    public ApiResponse<ChallengeResponseDTO.DeleteChallengeResponseDTO> deleteChallenge(@PathVariable("userChallengeId") Long userChallengeId) {
+    public ApiResponse<Void> deleteChallenge(@PathVariable("userChallengeId") Long userChallengeId) {
         //AccessToken에서 userId 추출
         Authentication authentication = SecurityContextHolder.getContext().getAuthentication();
         Long userId = (Long) authentication.getPrincipal();
 
-        ChallengeResponseDTO.DeleteChallengeResponseDTO deleteChallenge = challengeCommandService.delete(userChallengeId, userId);
-        return ApiResponse.onSuccess(deleteChallenge);
+        challengeCommandService.delete(userChallengeId, userId);
+        return ApiResponse.onSuccess();
     }
 }

src/main/java/umc/GrowIT/Server/web/controller/ChallengeController.java

@@ -124,5 +124,5 @@ ApiResponse<ChallengeResponseDTO.ModifyProofDTO> updateChallengeProof(@PathVaria
 
     })
     @Parameter(name = "userChallengeId", description = "삭제할 사용자 챌린지의 ID", example = "1")
-    ApiResponse<ChallengeResponseDTO.DeleteChallengeResponseDTO> deleteChallenge(@PathVariable("userChallengeId") Long userChallengeId);
+    ApiResponse<Void> deleteChallenge(@PathVariable("userChallengeId") Long userChallengeId);
 }

src/main/java/umc/GrowIT/Server/web/controller/specification/ChallengeSpecification.java

@@ -205,18 +205,6 @@ public static class ModifyProofDTO {
         private String thoughts;
     }
 
-    @Getter
-    @Builder
-    @NoArgsConstructor
-    @AllArgsConstructor
-    @Schema(title = "챌린지 삭제 response")
-    public static class DeleteChallengeResponseDTO {
-        @Schema(description = "사용자 챌린지 id", example = "1")
-        private Long id;
-        @Schema(description = "챌린지 삭제 성공 메시지", example = "챌린지를 삭제했어요.")
-        private String message;
-    }
-
     @Getter
     @Builder
     @NoArgsConstructor