Add postmark-templates-parse and postmark-templates-from-file.

randytarampi · randytarampi · commit ee632f2d6e7f · 2018-01-07T21:54:36.000-08:00
Support both the original task target based upload that `ActiveCampaign/mailmason#34` is dependent on, as well as a stripped down version of its [`postmark-templates-generate`](ActiveCampaign/mailmason@9af44cc#diff-84d8d4faaac8ca7bfe33ab2e934307c1R9) task, which just blindly reads email template configurations and applies them as task target configuration for `postmark-templates-upload`. I'm not too keen on the duplication between this and mailmason, but I don't know how else I'd iron things out other than by making mailmason write a file in its `postmark-templates-generate`, but that seems overly wasteful.
diff --git a/Gruntfile.js b/Gruntfile.js
@@ -57,10 +57,16 @@ module.exports = function (grunt) {
 
     "postmark-templates-output": {
       options: {
-        cleanOutput: "<%= config.templates && config.templates.cleanOutput %>",
-        outputFile: "<%= config.templates && config.templates.outputFile %>",
-        ephemeralUploadResultsProperty: "<%= config.templates && config.templates.ephemeralUploadResultsProperty %>"
-      },
+          cleanOutput: "<%= config.templates && config.templates.cleanOutput %>",
+          outputFile: "<%= config.templates && config.templates.outputFile || config.templates && config.templates.file %>",
+          ephemeralUploadResultsProperty: "<%= config.templates && config.templates.ephemeralUploadResultsProperty %>"
+      }
+    },
+
+    "postmark-templates-parse": {
+      options: {
+        inputFile: "<%= config.templates && config.templates.inputFile || config.templates && config.templates.file %>"
+      }
     }
   });
 
diff --git a/example_config.json b/example_config.json
@@ -11,6 +11,6 @@
   "templates": {
     "ephemeralUploadResultsProperty": "postmark-templates-upload-results",
     "cleanOutput": true,
-    "outputFile": "templates.json"
+    "file": "templates.json"
   }
 }
diff --git a/example_templates.json b/example_templates.json
@@ -0,0 +1,20 @@
+{
+  "test_email": {
+    "name": "testing-postmark-templates-js1",
+    "subject": "Testing grunt-postmark-templates",
+    "htmlSrc": "test/email.html",
+    "textSrc": "test/email.txt"
+  },
+  "test_email_again": {
+    "name": "testing-postmark-templates-js2",
+    "subject": "Testing grunt-postmark-templates (again)",
+    "htmlSrc": "test/email.html",
+    "textSrc": "test/email.txt"
+  },
+  "test_email_inline_body": {
+    "name": "testing-postmark-templates-js3",
+    "subject": "Testing grunt-postmark-templates (inline body)",
+    "htmlBody": "<html><body><h1>Another email test</h1></body></html>",
+    "textBody": "Hello from grunt-postmark-templates\n"
+  }
+}
diff --git a/tasks/grunt-postmark-templates.js b/tasks/grunt-postmark-templates.js
@@ -10,6 +10,20 @@ module.exports = function (grunt) {
   var DEFAULT_OUTPUT_FILE_NAME = 'templates.json';
   var DEFAULT_CLEAN_OUTPUT = false;
 
+  grunt.registerTask('postmark-templates-parse', 'Parse Postmark templates for update', function () {
+    var options = this.options({
+      inputFile: DEFAULT_OUTPUT_FILE_NAME
+    });
+    var templateObjects = grunt.file.readJSON(options.inputFile || DEFAULT_OUTPUT_FILE_NAME);
+
+    grunt.config.set('postmark-templates-upload', Object.assign(
+      templateObjects,
+      {
+        options: grunt.config.get('postmark-templates-upload.options')
+      }
+    ));
+  });
+
   grunt.registerMultiTask('postmark-templates-upload', 'Create or update Postmark templates', function () {
     var done = this.async();
     var options = this.options({
@@ -49,7 +63,7 @@ module.exports = function (grunt) {
       Subject: template.subject,
       HtmlBody: template.htmlBody || grunt.file.read(template.htmlSrc),
       TextBody: template.textBody || grunt.file.read(template.textSrc),
-      TemplateId: template.templateId,
+      TemplateId: template.templateId
     };
 
     if (expanded.TemplateId) {
@@ -134,5 +148,7 @@ module.exports = function (grunt) {
   });
 
   // you can also get a JSON report of uploaded templates
-  grunt.registerTask('postmark-templates', ['postmark-templates-upload', 'postmark-templates-output']);
+  grunt.registerTask('postmark-templates-from-targets', ['postmark-templates-upload', 'postmark-templates-output']);
+  grunt.registerTask('postmark-templates-from-file', ['postmark-templates-parse', 'postmark-templates-from-targets']);
+  grunt.registerTask('postmark-templates', ['postmark-templates-from-targets']);
 };

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,6 @@`
`11`	`11`	`"templates": {`
`12`	`12`	`"ephemeralUploadResultsProperty": "postmark-templates-upload-results",`
`13`	`13`	`"cleanOutput": true,`
`14`		`- "outputFile": "templates.json"`
	`14`	`+ "file": "templates.json"`
`15`	`15`	`}`
`16`	`16`	`}`