Fixed issues with faction npc crafting

Author: AdamKyle

resources/js/game/components/faction-loyalty/faction-npc-tasks.tsx

@@ -142,6 +142,20 @@ export default class FactionNpcTasks extends React.Component<
         );
     }
 
+    isCraftingTaskButtonDisabled(fameTask: FameTasks) {
+        return (
+            !this.props.can_craft ||
+            this.state.crafting ||
+            this.state.must_revive ||
+            fameTask.current_amount === fameTask.required_amount ||
+            !this.props.faction_loyalty_npc.currently_helping ||
+            !(
+                this.props.faction_loyalty_npc.npc.game_map_id ===
+                this.props.character_map_id
+            )
+        );
+    }
+
     renderTasks(fameTasks: FameTasks[], bounties: boolean) {
         return fameTasks
             .filter((fameTask: FameTasks) => {
@@ -188,15 +202,9 @@ export default class FactionNpcTasks extends React.Component<
                                                 fameTask.item_id,
                                             );
                                         }}
-                                        disabled={
-                                            !this.props.can_craft ||
-                                            this.state.crafting ||
-                                            this.state.must_revive ||
-                                            fameTask.current_amount ===
-                                                fameTask.required_amount ||
-                                            !this.props.faction_loyalty_npc
-                                                .currently_helping
-                                        }
+                                        disabled={this.isCraftingTaskButtonDisabled(
+                                            fameTask,
+                                        )}
                                     />
                                 )}
                             </div>

resources/js/game/components/hooks/definitions/use-character-inventory-visibility.ts

@@ -0,0 +1,48 @@
+import { useEventSystem } from "event-system/hooks/use-event-system";
+import { useEffect, useState } from "react";
+
+import UseCharacterInventoryVisibility from "./definitions/use-character-inventory-visibility";
+import UseCharacterInventoryVisibilityState from "./types/use-character-inventory-visibility-state";
+import { CharacterSheet } from "../character-sheet/event-types/character-sheet";
+
+export const useCharacterInventoryVisibility =
+    (): UseCharacterInventoryVisibility => {
+        const eventSystem = useEventSystem();
+
+        const [showCharacterInventory, setShowCharacterInventory] =
+            useState<
+                UseCharacterInventoryVisibilityState["showCharacterInventory"]
+            >(false);
+
+        const characterInventoryVisibility =
+            eventSystem.fetchOrCreateEventEmitter<{
+                [key: string]: boolean;
+            }>(CharacterSheet.OPEN_INVENTORY_SECTION);
+
+        useEffect(() => {
+            const updateVisibility = (visible: boolean) => {
+                setShowCharacterInventory(visible);
+            };
+
+            characterInventoryVisibility.on(
+                CharacterSheet.OPEN_INVENTORY_SECTION,
+                updateVisibility,
+            );
+
+            return () => {
+                characterInventoryVisibility.off(
+                    CharacterSheet.OPEN_INVENTORY_SECTION,
+                    updateVisibility,
+                );
+            };
+        }, [characterInventoryVisibility]);
+
+        const closeInventory = () => {
+            characterInventoryVisibility.emit(
+                CharacterSheet.OPEN_INVENTORY_SECTION,
+                false,
+            );
+        };
+
+        return { showCharacterInventory, closeInventory };
+    };

resources/js/game/components/hooks/definitions/use-character-sheet-visibility-definition.ts

@@ -0,0 +1,39 @@
+import { useEventSystem } from "event-system/hooks/use-event-system";
+import { useState, useEffect } from "react";
+
+import UseCharacterSheetVisibilityState from "./types/use-character-sheet-visibility-state";
+import { CharacterSheet } from "../character-sheet/event-types/character-sheet";
+
+export const useCharacterSheetVisibility =
+    (): UseCharacterSheetVisibilityState => {
+        const eventSystem = useEventSystem();
+
+        const [showCharacterSheet, setShowCharacterSheet] =
+            useState<UseCharacterSheetVisibilityState["showCharacterSheet"]>(
+                false,
+            );
+
+        const characterSheetVisibility = eventSystem.fetchOrCreateEventEmitter<{
+            [key: string]: boolean;
+        }>(CharacterSheet.OPEN_CHARACTER_SHEET);
+
+        useEffect(() => {
+            const updateVisibility = (visible: boolean) => {
+                setShowCharacterSheet(visible);
+            };
+
+            characterSheetVisibility.on(
+                CharacterSheet.OPEN_CHARACTER_SHEET,
+                updateVisibility,
+            );
+
+            return () => {
+                characterSheetVisibility.off(
+                    CharacterSheet.OPEN_CHARACTER_SHEET,
+                    updateVisibility,
+                );
+            };
+        }, [characterSheetVisibility]);
+
+        return { showCharacterSheet };
+    };